From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B556C2BB86 for ; Sat, 11 Apr 2020 23:49:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 15915206F7 for ; Sat, 11 Apr 2020 23:49:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586648940; bh=aGrhEt/F8+bpz/cCJNrqcJheN8rY2vgZLZ66af+Iq2Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Llu+kWYaHpVDtOTmVj/8j0I1RnDTg6aYe6RUMXoBJ/w4f5nokbQhX5W3MNbrT110J RFs73WVhiMxvHj1DV7a1G5eySncoS81uw9+kQElloGyJRzQJ/0WYdF3ryqeUOnuRmT Rdx3d5vlQJz4o7fqEE7hR6S8icOjHAoEc67oghd4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727835AbgDKXsx (ORCPT ); Sat, 11 Apr 2020 19:48:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:37928 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727202AbgDKXEa (ORCPT ); Sat, 11 Apr 2020 19:04:30 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3595F215A4; Sat, 11 Apr 2020 23:04:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586646271; bh=aGrhEt/F8+bpz/cCJNrqcJheN8rY2vgZLZ66af+Iq2Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Pwd5gxoMyijF1ceO/N8q0ePJwPhu7AbdDlvKuVrIxbWauDJENcoB9BWupuYZFo1qy MJAmVEBLxo5XO/vgpjE6pHKA6o1wp1qLfmS2mRY3siX70N66kfnrQRffEV/kKsskZ9 3kizNwsHgY6t5ZCx822cnYyZIybDPZPKLY/G1lCk= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Vlad Buslov , Roi Dayan , Sasha Levin , netdev@vger.kernel.org, linux-rdma@vger.kernel.org Subject: [PATCH AUTOSEL 5.6 035/149] net/mlx5e: Init ethtool steering for representors Date: Sat, 11 Apr 2020 19:01:52 -0400 Message-Id: <20200411230347.22371-35-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200411230347.22371-1-sashal@kernel.org> References: <20200411230347.22371-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Vlad Buslov [ Upstream commit 6783e8b29f636383af293a55336f036bc7ad5619 ] During transition to uplink representors the code responsible for initializing ethtool steering functionality wasn't added to representor init rx routine. This causes NULL pointer dereference during configuration of network flow classification rule with ethtool (only possible to reproduce with next commit in this series which registers necessary ethtool callbacks). Signed-off-by: Vlad Buslov Reviewed-by: Roi Dayan Signed-off-by: Sasha Levin --- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c index 6ed307d7f1914..937ab57b98c44 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c @@ -1660,6 +1660,8 @@ static int mlx5e_init_rep_rx(struct mlx5e_priv *priv) if (err) goto err_destroy_ttc_table; + mlx5e_ethtool_init_steering(priv); + return 0; err_destroy_ttc_table: -- 2.20.1