From: Greg KH <gregkh@linuxfoundation.org>
To: Sasha Levin <sashal@kernel.org>
Cc: valex@mellanox.com, jgg@mellanox.com, lariel@mellanox.com,
leonro@mellanox.com, stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] IB/mlx5: Replace tunnel mpls capability bits for" failed to apply to 4.19-stable tree
Date: Tue, 14 Apr 2020 09:39:42 +0200 [thread overview]
Message-ID: <20200414073942.GD4111599@kroah.com> (raw)
In-Reply-To: <20200414022659.GB1068@sasha-vm>
On Mon, Apr 13, 2020 at 10:26:59PM -0400, Sasha Levin wrote:
> On Fri, Apr 10, 2020 at 11:01:43AM +0200, gregkh@linuxfoundation.org wrote:
> >
> > The patch below does not apply to the 4.19-stable tree.
> > If someone wants it applied there, or to any other stable or longterm
> > tree, then please email the backport, including the original git commit
> > id to <stable@vger.kernel.org>.
> >
> > thanks,
> >
> > greg k-h
> >
> > ------------------ original commit in Linus's tree ------------------
> >
> > > From 41e684ef3f37ce6e5eac3fb5b9c7c1853f4b0447 Mon Sep 17 00:00:00 2001
> > From: Alex Vesker <valex@mellanox.com>
> > Date: Thu, 5 Mar 2020 14:38:41 +0200
> > Subject: [PATCH] IB/mlx5: Replace tunnel mpls capability bits for
> > tunnel_offloads
> >
> > Until now the flex parser capability was used in ib_query_device() to
> > indicate tunnel_offloads_caps support for mpls_over_gre/mpls_over_udp.
> >
> > Newer devices and firmware will have configurations with the flexparser
> > but without mpls support.
> >
> > Testing for the flex parser capability was a mistake, the tunnel_stateless
> > capability was intended for detecting mpls and was introduced at the same
> > time as the flex parser capability.
> >
> > Otherwise userspace will be incorrectly informed that a future device
> > supports MPLS when it does not.
> >
> > Link: https://lore.kernel.org/r/20200305123841.196086-1-leon@kernel.org
> > Cc: <stable@vger.kernel.org> # 4.17
> > Fixes: e818e255a58d ("IB/mlx5: Expose MPLS related tunneling offloads")
> > Signed-off-by: Alex Vesker <valex@mellanox.com>
> > Reviewed-by: Ariel Levkovich <lariel@mellanox.com>
> > Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> > Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
>
> The conflict was around the cqe_checksum_full cap bit being exposed by
> db849faa9bef ("net/mlx5e: Rx, Fix checksum calculation for new
> hardware").
>
> I've resolved it by exposing cqe_checksum_full, but *not* taking
> db849faa9bef.
Thanks for doing this!
greg k-h
prev parent reply other threads:[~2020-04-14 7:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-10 9:01 FAILED: patch "[PATCH] IB/mlx5: Replace tunnel mpls capability bits for" failed to apply to 4.19-stable tree gregkh
2020-04-14 2:26 ` Sasha Levin
2020-04-14 7:39 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414073942.GD4111599@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jgg@mellanox.com \
--cc=lariel@mellanox.com \
--cc=leonro@mellanox.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=valex@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).