Re: Patchset for CVE-2020-1749 Kernel 4.19

[Greg KH <gregkh@linuxfoundation.org>]

On Tue, Apr 14, 2020 at 10:05:09AM +0000, Schmid, Carsten wrote:
> > > Applies to stable linux-v4.19.y (with y=114).
> >
> > Have you been able to test these patches so that you know they work?
> >
> I did apply and compile on x86 in both 4.14 and 4.19 (making sure to have all CONFIG_s set
> to compile the changed code).
> I then ran 4.14 (project kernel) on our target; however i can't build an
> encrypted IPv6 tunnel to verify if the patchset helps.
> (From the patch descriptions, it really looks like they fix this)
> 
> IPv6 tunnel testing will be done by other folks in the project, i can't tell when due to
> the CoVid situation as this requires special equipment that i can't access at all.

Please wait to submit these until you can actually test that they solve
the issue involved.

> > And can you please send them as a patch series, not as attachments, and
> >  cc: all the original authors so that everyone can know what is going on
> > and weigh in if they see any issues?
> Of course. Sorry that i didn't do this yet.
> 
> >
> > And finally, do not change the changelog text from the original commits,
> > that's not ok.
> Except for the "upstream commit id", right?

Correct.

> > If you need to put any notes in there as to what you
> > did, follow the format we have been using for years, and put it in the
> > s-o-b: area in a small [ box ]
> >
> > Same for the 4.14 patches.
> >
> > thanks,
> >
> > greg k-h
> 
> Of course i will do so, if it makes sense due to little testing effort possible.
> Please give a short notice if you think i should resend the patch series.
> 
> One question:
> Our IT department adds a signature since a few days, after a line with "----".
> Is this a problem? I can't turn that off, unfortunately.
> (At least they keep the "text only" and don't switch to HTML)

Is it a problem for what, patches?  It shouldn't be.

thanks,

greg k-h