From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B248C2BB55 for ; Wed, 15 Apr 2020 13:27:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B2182076D for ; Wed, 15 Apr 2020 13:27:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586957268; bh=CuCbfoOUnAJndaAm6wMEbsySLEJNJ9B8ow4auQaOSG0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=pmguO3aKRAfvLBrkZETKrEhH4LCiIKd7/hZKs0Nu7Fjgmtj35f07biprXzbHk3ROU nQwLCjM57TGrSp0DtyFbcrn/yeqMhmahNqByuvvfchJBgtnw32XR68jaABSPVBlfY0 xcYEAlF88u8htpJfB6h1fI+nefvnnQQP+glcz0l0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2633185AbgDON1q (ORCPT ); Wed, 15 Apr 2020 09:27:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:60220 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2633128AbgDON1o (ORCPT ); Wed, 15 Apr 2020 09:27:44 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E6CB220575; Wed, 15 Apr 2020 13:27:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586957264; bh=CuCbfoOUnAJndaAm6wMEbsySLEJNJ9B8ow4auQaOSG0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Uh5jaC1UPWLmGeCNYvWT5Z0r53lMWyPirXRu/epJBz9gubro42FRf2ibjNv46YL6G Ah+btDTn4vd0swLhRL01GhQhnWpOgxxEna38wnknyi0HWFIRf+D3XoA3iGLg5DFJlK qrHjejcdcQgliT2aS9+M0m+iw1fTNi+J7DI4T32Y= Date: Wed, 15 Apr 2020 15:27:42 +0200 From: Greg KH To: Sakari Ailus Cc: stable@vger.kernel.org, david@unsolicited.net, hans.verkuil@cisco.com, linux@roeck-us.net, mchehab@osg.samsung.com, stable-commits@vger.kernel.org Subject: Re: Patch "Revert "[media] videobuf2-v4l2: Verify planes array in buffer dequeueing"" has been added to the 4.4-stable tree Message-ID: <20200415132742.GA3461248@kroah.com> References: <158694575418840@kroah.com> <20200415131412.GD27762@paasikivi.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200415131412.GD27762@paasikivi.fi.intel.com> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Apr 15, 2020 at 04:14:12PM +0300, Sakari Ailus wrote: > Hi Greg, > > On Wed, Apr 15, 2020 at 12:15:54PM +0200, gregkh@linuxfoundation.org wrote: > > > > This is a note to let you know that I've just added the patch titled > > > > Revert "[media] videobuf2-v4l2: Verify planes array in buffer dequeueing" > > > > to the 4.4-stable tree which can be found at: > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > > > The filename of the patch is: > > revert-videobuf2-v4l2-verify-planes-array-in-buffer-dequeueing.patch > > and it can be found in the queue-4.4 subdirectory. > > > > If you, or anyone else, feels it should not be added to the stable tree, > > please let know about it. > > > > > > From 93f0750dcdaed083d6209b01e952e98ca730db66 Mon Sep 17 00:00:00 2001 > > From: Mauro Carvalho Chehab > > Date: Wed, 11 May 2016 13:09:34 -0300 > > Subject: Revert "[media] videobuf2-v4l2: Verify planes array in buffer dequeueing" > > > > From: Mauro Carvalho Chehab > > > > commit 93f0750dcdaed083d6209b01e952e98ca730db66 upstream. > > This patch has been already applied to the 4.4-stable tree --- and the > original has been re-applied as well, just as in upstream. > > The original revert was done because another patch was missing the tree > (commit 93f0750dcdaed083d6209b01e952e98ca730db66 upstream), not because > there was a problem with the patch itself. > > In other words, this patch must be dropped. Really? This is a mess. I see the following commits in the stable 4.4 tree: In the 4.4.9 release the following upstream commit was backported: 2c1f6951a8a8 ("[media] videobuf2-v4l2: Verify planes array in buffer dequeueing") then in 4.4.11 it was reverted by backporting: 93f0750dcdae ("Revert "[media] videobuf2-v4l2: Verify planes array in buffer dequeueing"") Then finally, in 4.4.19 this commit gets added: 83934b75c368 ("[media] videobuf2-v4l2: Verify planes array in buffer dequeueing") So, is 83934b75c368 ok to backport, but 2c1f6951a8a8 was not? Because they look identical to me... So, what am I missing here? thanks, greg k-h