From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: jsmart2021@gmail.com, dick.kennedy@broadcom.com,
martin.petersen@oracle.com, stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] scsi: lpfc: Fix broken Credit Recovery after driver load" failed to apply to 5.4-stable tree
Date: Wed, 15 Apr 2020 21:46:00 -0400 [thread overview]
Message-ID: <20200416014600.GU1068@sasha-vm> (raw)
In-Reply-To: <1586949527184166@kroah.com>
On Wed, Apr 15, 2020 at 01:18:47PM +0200, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 5.4-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From 835214f5d5f516a38069bc077c879c7da00d6108 Mon Sep 17 00:00:00 2001
>From: James Smart <jsmart2021@gmail.com>
>Date: Mon, 27 Jan 2020 16:23:03 -0800
>Subject: [PATCH] scsi: lpfc: Fix broken Credit Recovery after driver load
>
>When driver is set to enable bb credit recovery, the switch displayed the
>setting as inactive. If the link bounces, it switches to Active.
>
>During link up processing, the driver currently does a MBX_READ_SPARAM
>followed by a MBX_CONFIG_LINK. These mbox commands are queued to be
>executed, one at a time and the completion is processed by the worker
>thread. Since the MBX_READ_SPARAM is done BEFORE the MBX_CONFIG_LINK, the
>BB_SC_N bit is never set the the returned values. BB Credit recovery status
>only gets set after the driver requests the feature in CONFIG_LINK, which
>is done after the link up. Thus the ordering of READ_SPARAM needs to follow
>the CONFIG_LINK.
>
>Fix by reordering so that READ_SPARAM is done after CONFIG_LINK. Added a
>HBA_DEFER_FLOGI flag so that any FLOGI handling waits until after the
>READ_SPARAM is done so that the proper BB credit value is set in the FLOGI
>payload.
>
>Fixes: 6bfb16208298 ("scsi: lpfc: Fix configuration of BB credit recovery in service parameters")
>Cc: <stable@vger.kernel.org> # v5.4+
>Link: https://lore.kernel.org/r/20200128002312.16346-4-jsmart2021@gmail.com
>Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
>Signed-off-by: James Smart <jsmart2021@gmail.com>
>Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
I've grabbed these additional fixes to address the conflict:
6bfb16208298 ("scsi: lpfc: Fix configuration of BB credit recovery in service parameters")
e3ba04c9bad1 ("scsi: lpfc: Fix Fabric hostname registration if system hostname changes")
93a4d6f40198 ("scsi: lpfc: Add registration for CPU Offline/Online events")
--
Thanks,
Sasha
prev parent reply other threads:[~2020-04-16 1:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 11:18 FAILED: patch "[PATCH] scsi: lpfc: Fix broken Credit Recovery after driver load" failed to apply to 5.4-stable tree gregkh
2020-04-16 1:46 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416014600.GU1068@sasha-vm \
--to=sashal@kernel.org \
--cc=dick.kennedy@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=jsmart2021@gmail.com \
--cc=martin.petersen@oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).