From: Sasha Levin <sashal@kernel.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
"# 3.4.x" <stable@vger.kernel.org>,
Guenter Roeck <groeck@google.com>,
Nathan Chancellor <natechancellor@gmail.com>,
kbuild test robot <lkp@intel.com>,
cros-kernel-buildreports@googlegroups.com,
kbuild-all@lists.01.org,
clang-built-linux <clang-built-linux@googlegroups.com>
Subject: Re: [chrome-os:chromeos-4.19 21350/21402] drivers/misc/echo/echo.c:384:27: error: equality comparison with extraneous parentheses
Date: Wed, 15 Apr 2020 23:31:00 -0400 [thread overview]
Message-ID: <20200416033100.GH1068@sasha-vm> (raw)
In-Reply-To: <CAKwvOdnOuMcjzsqTt2aVtoiKN3L9zOONGX-4BJgRWedeWspWTA@mail.gmail.com>
On Wed, Apr 15, 2020 at 10:51:37AM -0700, Nick Desaulniers wrote:
>On Tue, Apr 14, 2020 at 5:56 PM 'Guenter Roeck' via Clang Built Linux
><clang-built-linux@googlegroups.com> wrote:
>>
>> On Tue, Apr 14, 2020 at 5:26 PM Nathan Chancellor
>> <natechancellor@gmail.com> wrote:
>> >
>> > Hi all,
>> >
>> > Sorry for yet another convergeance on this commit... :/ hopefully this
>> > does not continue for much longer. None of the warnings are obviously
>> > caused by the patch below.
>>> Fixed by commit 85dc2c65e6c9 ("misc: echo: Remove unnecessary
>>> parentheses and simplify check for zero").
>> >
>> No worries.
>>
>> I noticed that the problems are pretty much all fixed in the upstream
>> kernel. I just wasn't sure if it would be worthwhile sending a request
>> to stable@ to have them applied to 4.19.y (and if necessary 5.4.y).
>> Any suggestions ?
>
>We should strive to be warning free on stable. Thanks for identifying
>the fix Nathan.
>
>Greg, Sasha,
>Would you please cherry pick 85dc2c65e6c9 to 4.19.y, 4.14.y, 4.9.y,
>and 4.4.y (maybe 3.18, didn't check that one)? It applies cleanly and
>is a trivial fix for a warning that landed in v4.20-rc1.
I'll grab it, but could we please look into disabling some clang
warnings?
I understand warnings that might warn us about dangerous code, but this
reads to me like something checkpatch might complain about...
--
Thanks,
Sasha
next prev parent reply other threads:[~2020-04-16 3:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202004150637.9F62YI28%lkp@intel.com>
[not found] ` <20200415002618.GB19509@ubuntu-s3-xlarge-x86>
[not found] ` <CABXOdTd-TSKR+x4ALQXAD9VGxd4sQCCVC9hzdGamyUr-ndBJ+w@mail.gmail.com>
2020-04-15 17:51 ` [chrome-os:chromeos-4.19 21350/21402] drivers/misc/echo/echo.c:384:27: error: equality comparison with extraneous parentheses Nick Desaulniers
2020-04-15 18:08 ` Kees Cook
2020-04-16 3:31 ` Sasha Levin [this message]
2020-04-16 3:39 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416033100.GH1068@sasha-vm \
--to=sashal@kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=cros-kernel-buildreports@googlegroups.com \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@google.com \
--cc=kbuild-all@lists.01.org \
--cc=lkp@intel.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox