From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92CE3C2BA2B for ; Thu, 16 Apr 2020 07:08:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 714DB215A4 for ; Thu, 16 Apr 2020 07:08:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587020885; bh=rqauh4Be6COPIZWaHV/gIXXxZqcbqy5avv+mBgZ/fqY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Crz+5ufbfGD2moky9kVhAgxRYF4XBKZKd72DHFDhKH0o218+/T3ZD2idvzmbyDqSl hl3EX8aqhkZSnzDyYkSSS6rhcklGiIov+c+wMMVjpqR+z9NMiYmajzLiNj1Dxa9Znl jfwcZ1SxrBsbp7uwJ9YhetrrWeq+SljDG79nS2j0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437862AbgDPHIE (ORCPT ); Thu, 16 Apr 2020 03:08:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:49398 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437060AbgDPHIB (ORCPT ); Thu, 16 Apr 2020 03:08:01 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DDD6020771; Thu, 16 Apr 2020 07:08:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587020881; bh=rqauh4Be6COPIZWaHV/gIXXxZqcbqy5avv+mBgZ/fqY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yvXaQ0hbLL8PB7viplS+9j6ghyh9QtRMpV08rrZl6n1FhiI/aDmzSQr1KEvf8IYP2 OJjweZy0jUBvMTn0AHuzxdAf8YpQhJa6hNyl4lDR+OW+aLu108tjNf/sFeobhZ7zPg drx1KnkpjtalWbwRoTMokU2vmbvciycc8TV3RJZ4= Date: Thu, 16 Apr 2020 09:07:59 +0200 From: Greg KH To: Sasha Levin Cc: chris@chris-wilson.co.uk, alexander.deucher@amd.com, kirill.shutemov@linux.intel.com, stable@vger.kernel.org Subject: Re: FAILED: patch "[PATCH] drm: Remove PageReserved manipulation from drm_pci_alloc" failed to apply to 4.19-stable tree Message-ID: <20200416070759.GD372946@kroah.com> References: <158695037014053@kroah.com> <20200416023121.GY1068@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200416023121.GY1068@sasha-vm> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Apr 15, 2020 at 10:31:21PM -0400, Sasha Levin wrote: > On Wed, Apr 15, 2020 at 01:32:50PM +0200, gregkh@linuxfoundation.org wrote: > > > > The patch below does not apply to the 4.19-stable tree. > > If someone wants it applied there, or to any other stable or longterm > > tree, then please email the backport, including the original git commit > > id to . > > > > thanks, > > > > greg k-h > > > > ------------------ original commit in Linus's tree ------------------ > > > > > From ea36ec8623f56791c6ff6738d0509b7920f85220 Mon Sep 17 00:00:00 2001 > > From: Chris Wilson > > Date: Sun, 2 Feb 2020 17:16:31 +0000 > > Subject: [PATCH] drm: Remove PageReserved manipulation from drm_pci_alloc > > > > drm_pci_alloc/drm_pci_free are very thin wrappers around the core dma > > facilities, and we have no special reason within the drm layer to behave > > differently. In particular, since > > > > commit de09d31dd38a50fdce106c15abd68432eebbd014 > > Author: Kirill A. Shutemov > > Date: Fri Jan 15 16:51:42 2016 -0800 > > > > page-flags: define PG_reserved behavior on compound pages > > > > As far as I can see there's no users of PG_reserved on compound pages. > > Let's use PF_NO_COMPOUND here. > > > > it has been illegal to combine GFP_COMP with SetPageReserved, so lets > > stop doing both and leave the dma layer to its own devices. > > > > Reported-by: Taketo Kabe > > Bug: https://gitlab.freedesktop.org/drm/intel/issues/1027 > > Fixes: de09d31dd38a ("page-flags: define PG_reserved behavior on compound pages") > > Signed-off-by: Chris Wilson > > Cc: # v4.5+ > > Reviewed-by: Alex Deucher > > Link: https://patchwork.freedesktop.org/patch/msgid/20200202171635.4039044-1-chris@chris-wilson.co.uk > > We didn't have 750afb08ca71 ("cross-tree: phase out > dma_zalloc_coherent()") on older kernels. Fixed and queued up. Thanks for this, and all the other FAILED: fixes as well. greg k-h