From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76892C2D0EF for ; Sat, 18 Apr 2020 10:53:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F4B62220A for ; Sat, 18 Apr 2020 10:53:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587207208; bh=93ZwolTNqVKstj50vqoDQzMO1nIwhAGCGrvIWwJ6PCY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=uR8mHwcio/aMpmvJb+k6mIHp9Mo6euCKpnuO4btcWBuiBQHOXSCCfGrCxrIJ40/LK raKQqBGr1CaVUbdvSU+d6i+USzeypUDl6ZVHx3Q52w4b4xGZgVWA6NiKVRIpuzbI8n u5rosfw4iYua7YJGFYVpuHPYNu+IZffMJQrqdyu8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725869AbgDRKx1 (ORCPT ); Sat, 18 Apr 2020 06:53:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:43318 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725857AbgDRKx1 (ORCPT ); Sat, 18 Apr 2020 06:53:27 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F23F121D82; Sat, 18 Apr 2020 10:53:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587207207; bh=93ZwolTNqVKstj50vqoDQzMO1nIwhAGCGrvIWwJ6PCY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rvJeAEuax2vQ31D5a2ixsqXUsCA8L9DJ8hQh1yaKaS7N3E0lkMxiJA6Afb0lC4vBK TOfhZ5Jgi88u5msh+jX93EITOCuaLs2ihi4CqqyY5IlNk/AJ+OGe66D3089lmopdsv +od3oAOoOO2fXk94UcHRh1bZSdlR9ru3i8y2zUAU= Date: Sat, 18 Apr 2020 12:53:25 +0200 From: Greg KH To: Delio Brignoli Cc: stable@vger.kernel.org Subject: Re: usb: dwc3: gadget: Don't clear flags before transfer ended Message-ID: <20200418105325.GA2875820@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Sat, Apr 18, 2020 at 12:25:16PM +0200, Delio Brignoli wrote: > Please apply the following commit: > > Commit subject: usb: dwc3: gadget: Don't clear flags before transfer ended > Commit ID: a114c4ca64bd522aec1790c7e5c60c882f699d8f > Apply to: at least 4.19 stable, and 5.4 stable if possible. Note that all kernels from v4.18-rc1 up to 5.7-rc1 are affected. > > Why apply it: > fixes . Without this fix the built-in USB function source/sink test module fails to work with isochronous endpoints [1]. A side-effect of setting dep->flags = DWC3_EP_ENABLED; in dwc3_gadget_ep_cleanup_completed_requests() as part of disabling an ep is that a subsequent attempt to enable the endpoint will skip __dwc3_gadget_ep_enable() effectively leaving the ep disabled. > > [1] Our gadget driver on TI AM5729 fails to work exactly like the built-in USB function source/sink test module when switching to alternate interface 1 because of the issue described above. > > TI is currently using 4.19 and 5.4 stable kernels as the basis for their processor SDK kernels for their AM57x SoC and may switch to 5.4 stable at a later time. Thank you. It does not apply to the 4.19.y kernel tree, can you provide a working backport of it please so that I can apply it? thanks, greg k-h