From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: maximmi@mellanox.com, saeedm@mellanox.com, tariqt@mellanox.com,
stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] net/mlx5e: Use preactivate hook to set the indirection table" failed to apply to 5.6-stable tree
Date: Sat, 18 Apr 2020 11:59:14 -0400 [thread overview]
Message-ID: <20200418155914.GA1809@sasha-vm> (raw)
In-Reply-To: <15872047304089@kroah.com>
On Sat, Apr 18, 2020 at 12:12:10PM +0200, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 5.6-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From fe867cac9e1967c553e4ac2aece5fc8675258010 Mon Sep 17 00:00:00 2001
>From: Maxim Mikityanskiy <maximmi@mellanox.com>
>Date: Mon, 4 Nov 2019 12:02:14 +0200
>Subject: [PATCH] net/mlx5e: Use preactivate hook to set the indirection table
>
>mlx5e_ethtool_set_channels updates the indirection table before
>switching to the new channels. If the switch fails, the indirection
>table is new, but the channels are old, which is wrong. Fix it by using
>the preactivate hook of mlx5e_safe_switch_channels to update the
>indirection table at the stage when nothing can fail anymore.
>
>As the code that updates the indirection table is now encapsulated into
>a new function, use that function in the attach flow when the driver has
>to reduce the number of channels, and prepare the code for the next
>commit.
>
>Fixes: 85082dba0a ("net/mlx5e: Correctly handle RSS indirection table when changing number of channels")
>Signed-off-by: Maxim Mikityanskiy <maximmi@mellanox.com>
>Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
>Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
I've grabbed these two dependencies for 5.6, 5.5, 5.4:
dca147b3dce5 ("net/mlx5e: Rename hw_modify to preactivate")
c2c95271f9f3 ("net/mlx5e: Encapsulate updating netdev queues into a function")
Older branches were more complex and still need a backport.
--
Thanks,
Sasha
prev parent reply other threads:[~2020-04-18 15:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-18 10:12 FAILED: patch "[PATCH] net/mlx5e: Use preactivate hook to set the indirection table" failed to apply to 5.6-stable tree gregkh
2020-04-18 15:59 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200418155914.GA1809@sasha-vm \
--to=sashal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=maximmi@mellanox.com \
--cc=saeedm@mellanox.com \
--cc=stable@vger.kernel.org \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).