Re: [regression 5.7-rc1] System does not power off, just halts

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Sat, Apr 18, 2020 at 10:09:28PM +0300, Thomas Backlund wrote:
> Den 14-04-2020 kl. 16:07, skrev Alex Deucher:
> > On Tue, Apr 14, 2020 at 4:21 AM Greg KH <greg@kroah.com> wrote:
> > > 
> > > On Mon, Apr 13, 2020 at 01:48:58PM -0400, Alex Deucher wrote:
> > > > On Mon, Apr 13, 2020 at 1:47 PM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
> > > > > 
> > > > > Dear Prike, dear Alex, dear Linux folks,
> > > > > 
> > > > > 
> > > > > Am 13.04.20 um 10:44 schrieb Paul Menzel:
> > > > > 
> > > > > > A regression between causes a system with the AMD board MSI B350M MORTAR
> > > > > > (MS-7A37) with an AMD Ryzen 3 2200G not to power off any more but just
> > > > > > to halt.
> > > > > > 
> > > > > > The regression is introduced in 9ebe5422ad6c..b032227c6293. I am in the
> > > > > > process to bisect this, but maybe somebody already has an idea.
> > > > > 
> > > > > I found the Easter egg:
> > > > > 
> > > > > > commit 487eca11a321ef33bcf4ca5adb3c0c4954db1b58
> > > > > > Author: Prike Liang <Prike.Liang@amd.com>
> > > > > > Date:   Tue Apr 7 20:21:26 2020 +0800
> > > > > > 
> > > > > >      drm/amdgpu: fix gfx hang during suspend with video playback (v2)
> > > > > > 
> > > > > >      The system will be hang up during S3 suspend because of SMU is pending
> > > > > >      for GC not respose the register CP_HQD_ACTIVE access request.This issue
> > > > > >      root cause of accessing the GC register under enter GFX CGGPG and can
> > > > > >      be fixed by disable GFX CGPG before perform suspend.
> > > > > > 
> > > > > >      v2: Use disable the GFX CGPG instead of RLC safe mode guard.
> > > > > > 
> > > > > >      Signed-off-by: Prike Liang <Prike.Liang@amd.com>
> > > > > >      Tested-by: Mengbing Wang <Mengbing.Wang@amd.com>
> > > > > >      Reviewed-by: Huang Rui <ray.huang@amd.com>
> > > > > >      Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> > > > > >      Cc: stable@vger.kernel.org
> > > > > 
> > > > > It reverts cleanly on top of 5.7-rc1, and this fixes the issue.
> > > > > 
> > > > > Greg, please do not apply this to the stable series. The commit message
> > > > > doesn’t even reference a issue/bug report, and doesn’t give a detailed
> > > > > problem description. What system is it?
> > > > > 
> > > > > Dave, Alex, how to proceed? Revert? I created issue 1094 [1].
> > > > 
> > > > Already fixed:
> > > > https://patchwork.freedesktop.org/patch/361195/
> > > 
> > > Any reason that doesn't have a cc: stable tag on it?
> > > 
> > > And is it committed to any tree at the moment?
> > 
> > It's going out in my -fixes pull this week with a stable tag.
> > 
> > Alex
> > 
> 
> 
> The fix is now in linus tree as:
> b2a7e9735ab2864330be9d00d7f38c961c28de5d
> 
> and should be added to fix all theese stable trees where the breakage got
> added despite the warnings in this thread:
> 
> releases/5.4.33/drm-amdgpu-fix-gfx-hang-during-suspend-with-video-pl.patch:[
> Upstream commit 487eca11a321ef33bcf4ca5adb3c0c4954db1b58 ]
> releases/5.6.5/drm-amdgpu-fix-gfx-hang-during-suspend-with-video-pl.patch:[
> Upstream commit 487eca11a321ef33bcf4ca5adb3c0c4954db1b58 ]
> releases/5.5.18/drm-amdgpu-fix-gfx-hang-during-suspend-with-video-pl.patch:[
> Upstream commit 487eca11a321ef33bcf4ca5adb3c0c4954db1b58 ]

Now queued up, thanks.

greg k-h