From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7F42C3A5A0 for ; Mon, 20 Apr 2020 12:44:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B76D720747 for ; Mon, 20 Apr 2020 12:44:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587386646; bh=eZOTwLQ+89n4izqg2qhLqC8W3atJDfDu9J0twFIibYk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=M24n+ji7TIMh0+XjGWYsJF4xFqu9zftWLfdj+aGj4dpVk7IoggJgjkBZHy3qQGC+i aitKd8JXrlIO6K1g/mKST7V6lFADnRMQc2b57SHy/EGJD1jCoHu47fRrA8f6HupvT9 b0oXj/vI5UvGESdwOwZ5qk/DusGG6HAd+w24ssj4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728508AbgDTMoF (ORCPT ); Mon, 20 Apr 2020 08:44:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:37832 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728505AbgDTMoD (ORCPT ); Mon, 20 Apr 2020 08:44:03 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3BD7A20738; Mon, 20 Apr 2020 12:44:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587386642; bh=eZOTwLQ+89n4izqg2qhLqC8W3atJDfDu9J0twFIibYk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UJ2NpiQCI7mbh6PVzSSjByAjC6kR4YpeypkIoWywYfwsWPj1qBuL3EE49SuoDyCxS PyPA7nye4I996bmwumfpZuxjPi63Y2Ex+C45vHswgLpR1Ziq+A0QJu0Z2p2JPOycRk 951Vk+8NqTgyV3Ktrh9jEd+r9hNf1af7K6cm5L0Y= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Thinh Nguyen , Felipe Balbi Subject: [PATCH 5.6 39/71] usb: dwc3: gadget: Dont clear flags before transfer ended Date: Mon, 20 Apr 2020 14:38:53 +0200 Message-Id: <20200420121517.193262046@linuxfoundation.org> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200420121508.491252919@linuxfoundation.org> References: <20200420121508.491252919@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Thinh Nguyen commit a114c4ca64bd522aec1790c7e5c60c882f699d8f upstream. We track END_TRANSFER command completion. Don't clear transfer started/ended flag prematurely. Otherwise, we'd run into the problem with restarting transfer before END_TRANSFER command finishes. Fixes: 6d8a019614f3 ("usb: dwc3: gadget: check for Missed Isoc from event status") Signed-off-by: Thinh Nguyen Signed-off-by: Felipe Balbi Signed-off-by: Greg Kroah-Hartman --- drivers/usb/dwc3/gadget.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -2570,10 +2570,8 @@ static void dwc3_gadget_endpoint_transfe dwc3_gadget_ep_cleanup_completed_requests(dep, event, status); - if (stop) { + if (stop) dwc3_stop_active_transfer(dep, true, true); - dep->flags = DWC3_EP_ENABLED; - } /* * WORKAROUND: This is the 2nd half of U1/U2 -> U0 workaround.