From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Sasha Levin <sashal@kernel.org>,
stable@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: [PATCH 4.9] arm64: cpu_errata: include required headers
Date: Tue, 21 Apr 2020 21:34:37 +0200 [thread overview]
Message-ID: <20200421193437.GA1420935@kroah.com> (raw)
In-Reply-To: <20200421192040.43080-1-natechancellor@gmail.com>
On Tue, Apr 21, 2020 at 12:20:41PM -0700, Nathan Chancellor wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> commit 94a5d8790e79ab78f499d2d9f1ff2cab63849d9f upstream.
>
> Without including psci.h and arm-smccc.h, we now get a build failure in
> some configurations:
>
> arch/arm64/kernel/cpu_errata.c: In function 'arm64_update_smccc_conduit':
> arch/arm64/kernel/cpu_errata.c:278:10: error: 'psci_ops' undeclared (first use in this function); did you mean 'sysfs_ops'?
>
> arch/arm64/kernel/cpu_errata.c: In function 'arm64_set_ssbd_mitigation':
> arch/arm64/kernel/cpu_errata.c:311:3: error: implicit declaration of function 'arm_smccc_1_1_hvc' [-Werror=implicit-function-declaration]
> arm_smccc_1_1_hvc(ARM_SMCCC_ARCH_WORKAROUND_2, state, NULL);
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
>
> Greg and Sasha,
>
> Please apply this to 4.9. The error in the commit message can be
> reproduced on 4.9.219 when CONFIG_ARM64_SSBD is enabled and
> CONFIG_HARDEN_BRANCH_PREDICTOR is disabled. It was reported to me by a
> user of one of my Android stable trees, where one of the configs in
> Qualcomm's 4.9 tree reproduced this issue.
>
> This commit is in 4.14 already so this should be the only tree where it
> is needed.
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2020-04-21 19:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 19:20 [PATCH 4.9] arm64: cpu_errata: include required headers Nathan Chancellor
2020-04-21 19:34 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200421193437.GA1420935@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=natechancellor@gmail.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).