From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96A1AC55189 for ; Wed, 22 Apr 2020 12:31:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7309D208E4 for ; Wed, 22 Apr 2020 12:31:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587558718; bh=Ec3XoTDhjcfPw4YUB5aIqmqqMvz7xRs+Asw2RsdFLq0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=SFpV86J7XeZLvjM0AzDfcm2G9VR7i862DCgKDOX531D3X93WUxN1GxrL+2P66mIr9 XINGMRpmQ+G4QBj31HjWJZIeI8YqocFjFcZ51BL81qpsyDvOptLJtkO0pOzGqI3KZP oxSkkMKFsY72yGu25+H2gavKXDXY9azFlkXFHmsk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726018AbgDVMb6 (ORCPT ); Wed, 22 Apr 2020 08:31:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:42790 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726002AbgDVMb5 (ORCPT ); Wed, 22 Apr 2020 08:31:57 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A7EE62082E; Wed, 22 Apr 2020 12:31:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587558717; bh=Ec3XoTDhjcfPw4YUB5aIqmqqMvz7xRs+Asw2RsdFLq0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zsgX877+gHxe/qHcsagt4rfH5jnkh4ntosk0vYdWUsosIbhgKvyB04v61gdhmm0Ua Xco/vz7iLyiKDzJ/biVPhQ9jx3tweMICoOtawYe9uI+OnG6CSORuSVKYEy5ayhbION +HM0J2BKSA13e5SfnaQtoLv8JgMZpFLmR0Misidg= Date: Wed, 22 Apr 2020 14:31:54 +0200 From: Greg Kroah-Hartman To: Lee Jones Cc: stable@vger.kernel.org, Alexey Brodkin , Alexey Brodkin , Geert Uytterhoeven , David Laight , Peter Zijlstra , Thomas Gleixner , Vineet Gupta , Will Deacon Subject: Re: [PATCH 4.9 04/21] devres: Align data[] to ARCH_KMALLOC_MINALIGN Message-ID: <20200422123154.GA3144508@kroah.com> References: <20200422111957.569589-1-lee.jones@linaro.org> <20200422111957.569589-5-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200422111957.569589-5-lee.jones@linaro.org> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Apr 22, 2020 at 12:19:40PM +0100, Lee Jones wrote: > From: Alexey Brodkin > > [ Upstream commit a66d972465d15b1d89281258805eb8b47d66bd36 ] > > Initially we bumped into problem with 32-bit aligned atomic64_t > on ARC, see [1]. And then during quite lengthly discussion Peter Z. > mentioned ARCH_KMALLOC_MINALIGN which IMHO makes perfect sense. > If allocation is done by plain kmalloc() obtained buffer will be > ARCH_KMALLOC_MINALIGN aligned and then why buffer obtained via > devm_kmalloc() should have any other alignment? > > This way we at least get the same behavior for both types of > allocation. > > [1] http://lists.infradead.org/pipermail/linux-snps-arc/2018-July/004009.html > [2] http://lists.infradead.org/pipermail/linux-snps-arc/2018-July/004036.html > > Signed-off-by: Alexey Brodkin > Cc: Greg Kroah-Hartman > Cc: Geert Uytterhoeven > Cc: David Laight > Cc: Peter Zijlstra > Cc: Thomas Gleixner > Cc: Vineet Gupta > Cc: Will Deacon > Cc: Greg KH > Cc: # 4.8+ > Signed-off-by: Greg Kroah-Hartman > Signed-off-by: Lee Jones > --- > drivers/base/devres.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) Sony ships this thing? Wow... Ok, I'll take it (for the next round), but supposidly it only affected ARC systems, which I'm pretty sure are not Sony phones :) greg k-h