stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Suraj Jitindar Singh <surajjs@amazon.com>
To: <stable@vger.kernel.org>
Cc: <sjitindarsingh@gmail.com>, <linux-xfs@vger.kernel.org>,
	"Suraj Jitindar Singh" <surajjs@amazon.com>
Subject: [PATCH STABLE v4.14.y 0/2] xfs: Backport two fixes
Date: Fri, 24 Apr 2020 16:05:30 -0700	[thread overview]
Message-ID: <20200424230532.2852-1-surajjs@amazon.com> (raw)

This series backports two patches which fix known bugs in the xfs
filesystem code to the v4.14.y stable tree.

They are each verified by the xfs tests xfs/439 and generic/585
respectively.

The first patch applies cleanly.

The second patch required slight massage due to the last code block
being removed having changed slightly upstream due to rework. I think
the backport is functionally equivalent.
Only thing is I request comment that it is correct to use the following
error path:

	ASSERT(VFS_I(wip)->i_nlink == 0);
	error = xfs_iunlink_remove(tp, wip);
	if (error)
>	       goto out_trans_cancel;

The old error patch out_bmap_cancel still exists here. However as
nothing can have modified the deferred ops struct at this point I
believe it is sufficient to go to the "out_trans_cancel" error label.

Darrick J. Wong (1):
  xfs: validate sb_logsunit is a multiple of the fs blocksize

kaixuxia (1):
  xfs: Fix deadlock between AGI and AGF with RENAME_WHITEOUT

 fs/xfs/xfs_inode.c | 85 +++++++++++++++++++++++-----------------------
 fs/xfs/xfs_log.c   | 14 +++++++-
 2 files changed, 55 insertions(+), 44 deletions(-)

-- 
2.17.1


             reply	other threads:[~2020-04-24 23:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-24 23:05 Suraj Jitindar Singh [this message]
2020-04-24 23:05 ` [PATCH STABLE v4.14.y 1/2] xfs: validate sb_logsunit is a multiple of the fs blocksize Suraj Jitindar Singh
2020-04-24 23:05 ` [PATCH STABLE v4.14.y 2/2] xfs: Fix deadlock between AGI and AGF with RENAME_WHITEOUT Suraj Jitindar Singh
2020-04-25  1:49   ` Sasha Levin
2020-04-27 23:24     ` [PATCH STABLE 4.19.y] " Suraj Jitindar Singh
2020-04-28  9:02 ` [PATCH STABLE v4.14.y 0/2] xfs: Backport two fixes Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200424230532.2852-1-surajjs@amazon.com \
    --to=surajjs@amazon.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=sjitindarsingh@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).