From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EFB9C83007 for ; Tue, 28 Apr 2020 09:02:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6AD1C206D7 for ; Tue, 28 Apr 2020 09:02:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="QWOHAf8q"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Edye47JG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726956AbgD1JC5 (ORCPT ); Tue, 28 Apr 2020 05:02:57 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:55073 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726271AbgD1JC5 (ORCPT ); Tue, 28 Apr 2020 05:02:57 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BE45E5C0195; Tue, 28 Apr 2020 05:02:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 28 Apr 2020 05:02:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=p8eNY0xnZNFtAr72xYZInG4PLoa Gm0XNLJTzn92LVy0=; b=QWOHAf8q/LDOeUq71TnWybRJl0K/Jfr540x/wM5Owej mgDhPzn5M8Bj+4lWqyVReHD54bx3S4mkj2GeSP+z1uHYyp9gvxvr7JWGfXu+rprC wg9H2KirKQL9U0YerpIIHVgdZ9/ZGWS/L4McFc46iem+tcZgmTeGC9MGk57YtVpt VV5J55HRLh//kc2rhKiKF8NsbaY7rclimQL0zE4RQXtM0hQGLocpH/xshdWrdMjv lvAHcthSCeHDkkhj1wCtD13BVrVyZqBUeeWTec6uctDRpVEUwLdRDB52cg/IuByb WN7Nzb6nLwwM2ja9VTwyu8Q2Ed7tSsA/S4L1wH8PkGw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=p8eNY0 xnZNFtAr72xYZInG4PLoaGm0XNLJTzn92LVy0=; b=Edye47JG1WMcFNI10kojbg xQvC2ODZR5WIPa10dLqivksIAunNMq9sO+woS9V+ofw7Y6gA7Zp3n/2gkAVWGV7H iPemtjgwMcQGczaSq2P1tvK/1pTMMtCjEmUB8B0hSyw1ht0IgYJxpebWUj0d6Hrq XYCzAYBOh5YVHp5HHcYoU70eDcLHfq4Zrh4lzCmepT75rnTCVCyz/PJKpmGbyj1/ 7ygdNb6feVZitQPnjXuKr9xQSO14eS8PFx7Zxcf0srQd/Yzsi8TcsS5Mz7q5Rd// gBH/TfggPwWOKno8q9zFYpC7ngUScSFsl3HIW1CGigvlbQI1PohUAgICuWqMk3LQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedriedugdduudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepifhrvghgucfm jfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecukfhppeekfedrkeeirdekledruddtje enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgv gheskhhrohgrhhdrtghomh X-ME-Proxy: Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 38A473065EA1; Tue, 28 Apr 2020 05:02:55 -0400 (EDT) Date: Tue, 28 Apr 2020 11:02:52 +0200 From: Greg KH To: Suraj Jitindar Singh Cc: stable@vger.kernel.org, sjitindarsingh@gmail.com, linux-xfs@vger.kernel.org Subject: Re: [PATCH STABLE v4.14.y 0/2] xfs: Backport two fixes Message-ID: <20200428090252.GA1001680@kroah.com> References: <20200424230532.2852-1-surajjs@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200424230532.2852-1-surajjs@amazon.com> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, Apr 24, 2020 at 04:05:30PM -0700, Suraj Jitindar Singh wrote: > This series backports two patches which fix known bugs in the xfs > filesystem code to the v4.14.y stable tree. > > They are each verified by the xfs tests xfs/439 and generic/585 > respectively. > > The first patch applies cleanly. > > The second patch required slight massage due to the last code block > being removed having changed slightly upstream due to rework. I think > the backport is functionally equivalent. > Only thing is I request comment that it is correct to use the following > error path: > > ASSERT(VFS_I(wip)->i_nlink == 0); > error = xfs_iunlink_remove(tp, wip); > if (error) > > goto out_trans_cancel; > > The old error patch out_bmap_cancel still exists here. However as > nothing can have modified the deferred ops struct at this point I > believe it is sufficient to go to the "out_trans_cancel" error label. > > Darrick J. Wong (1): > xfs: validate sb_logsunit is a multiple of the fs blocksize > > kaixuxia (1): > xfs: Fix deadlock between AGI and AGF with RENAME_WHITEOUT > > fs/xfs/xfs_inode.c | 85 +++++++++++++++++++++++----------------------- > fs/xfs/xfs_log.c | 14 +++++++- > 2 files changed, 55 insertions(+), 44 deletions(-) All (including the 4.19 patch), now queued up, thanks. greg k-h