From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D7ABC83004 for ; Tue, 28 Apr 2020 18:38:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 22C3D20B1F for ; Tue, 28 Apr 2020 18:38:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588099084; bh=XxISZYI385Ve0ULnt0OBLJbYSHNcZOEQ8W2uuaUP7S0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=1kYDxREUt5s4n9YMLCxYnBWUVdYbPYGEhqfJJ2hMHEdZMjmre8VsYINjmZUW+uxSK loCCa3tVMob4wPR2yM21o5UgzzaM1urWLzhg9plMhmkiEkT/UxmVdrMfUfWLaEXLEF WVfSWejJzklghPLJJwCq9CKkTSJyRgBz7bSP5OQk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730151AbgD1SiD (ORCPT ); Tue, 28 Apr 2020 14:38:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:56288 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730573AbgD1SiA (ORCPT ); Tue, 28 Apr 2020 14:38:00 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 702A32076A; Tue, 28 Apr 2020 18:37:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588099079; bh=XxISZYI385Ve0ULnt0OBLJbYSHNcZOEQ8W2uuaUP7S0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=llBBRC/wmc1ELBEthPgNnDM3Ev8rPnvebh57nO2ObLs0Ln0FLWmDxeRRNfL5LTHUv ZHDPLa8P1iV6qSr8W71g8HvDRNxGK9vkJcrxpjLep6DetCX8MqEGGW2j5VPEZyTp2e XRfY2Z34ykilqOp/+kkrQR37cRVwo8kSGEkqeCxA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lin Yi , Takashi Iwai Subject: [PATCH 4.19 094/131] ALSA: usx2y: Fix potential NULL dereference Date: Tue, 28 Apr 2020 20:25:06 +0200 Message-Id: <20200428182236.795276533@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200428182224.822179290@linuxfoundation.org> References: <20200428182224.822179290@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Takashi Iwai commit 7686e3485253635c529cdd5f416fc640abaf076f upstream. The error handling code in usX2Y_rate_set() may hit a potential NULL dereference when an error occurs before allocating all us->urb[]. Add a proper NULL check for fixing the corner case. Reported-by: Lin Yi Cc: Link: https://lore.kernel.org/r/20200420075529.27203-1-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/usb/usx2y/usbusx2yaudio.c | 2 ++ 1 file changed, 2 insertions(+) --- a/sound/usb/usx2y/usbusx2yaudio.c +++ b/sound/usb/usx2y/usbusx2yaudio.c @@ -695,6 +695,8 @@ static int usX2Y_rate_set(struct usX2Yde us->submitted = 2*NOOF_SETRATE_URBS; for (i = 0; i < NOOF_SETRATE_URBS; ++i) { struct urb *urb = us->urb[i]; + if (!urb) + continue; if (urb->status) { if (!err) err = -ENODEV;