From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CEAEC47254 for ; Fri, 8 May 2020 13:18:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1BFF120870 for ; Fri, 8 May 2020 13:18:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588943904; bh=OEOXJp0GplwOqua4HXBdjeGkIycP+sjXal95fZYY9Dc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=x8Ajs0l9CtnaHv+GQLVaO0WkD8IvApTvTzoqRKU7croSf4fr6scO7iQ73C+T3Azu3 C3PO8cuLZHAXlNOAblgD2Ic2DDdaAIQniU+sWbS6s1ZN7tTM8uLvb7Zcgl8ya41P3t znvAkDH+es0djrTU7Lfb/1mKn1s+0VXHnRRZDygs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726770AbgEHNSX (ORCPT ); Fri, 8 May 2020 09:18:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:40614 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729030AbgEHMnE (ORCPT ); Fri, 8 May 2020 08:43:04 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 23C532495F; Fri, 8 May 2020 12:43:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588941783; bh=OEOXJp0GplwOqua4HXBdjeGkIycP+sjXal95fZYY9Dc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WtZ41GTfTlqVC3Jg2mPu2sm0OqYI98vlB30T/cA5gJikR1IEqNUnk/coxVpKfrPsk QzK2RKdyW0bc5RkW4AdrRLJ3weELwN0PFMGxzUHvVb/8qAxPy32g+vKRQr2IeRm4c4 p/c1Cm/GeS/BFNt2RPZLiFrwVu2G53/wQvzqJ9l4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alexey Khoroshilov , Mauro Carvalho Chehab Subject: [PATCH 4.4 170/312] [media] lirc_imon: do not leave imon_probe() with mutex held Date: Fri, 8 May 2020 14:32:41 +0200 Message-Id: <20200508123136.454970850@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200508123124.574959822@linuxfoundation.org> References: <20200508123124.574959822@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Alexey Khoroshilov commit b833d0df943d70682e288c38c96b8e7bfff4023a upstream. Commit af8a819a2513 ("[media] lirc_imon: simplify error handling code") lost mutex_unlock(&context->ctx_lock), so imon_probe() exits with the context->ctx_lock mutex acquired. The patch adds mutex_unlock(&context->ctx_lock) back. Found by Linux Driver Verification project (linuxtesting.org). Fixes: af8a819a2513 ("[media] lirc_imon: simplify error handling code") Signed-off-by: Alexey Khoroshilov Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/staging/media/lirc/lirc_imon.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/staging/media/lirc/lirc_imon.c +++ b/drivers/staging/media/lirc/lirc_imon.c @@ -885,12 +885,14 @@ static int imon_probe(struct usb_interfa vendor, product, ifnum, usbdev->bus->busnum, usbdev->devnum); /* Everything went fine. Just unlock and return retval (with is 0) */ + mutex_unlock(&context->ctx_lock); goto driver_unlock; unregister_lirc: lirc_unregister_driver(driver->minor); free_tx_urb: + mutex_unlock(&context->ctx_lock); usb_free_urb(tx_urb); free_rx_urb: