From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 881FFC38A2A for ; Fri, 8 May 2020 12:43:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6067324973 for ; Fri, 8 May 2020 12:43:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588941799; bh=D8sLH2taGBH1jwEvqLtqvnEN3ghJ4DGfw4UH7oD9zHY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=IB0LicXAqp6EKTztG05Z5shGqCNs6Zeeld/6Js2Iydjww8P3H9pQSp83TQ8FApxBL FEH5KX+S9/RHdLwkgra9LZV7071xNb5AQiliRaTS70BM48dM4WhGq47ubnm8NsJMho t/Sbi3sfZeYKY0KJoF7vCaIFIS7bujeIswoxihOs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727100AbgEHMnP (ORCPT ); Fri, 8 May 2020 08:43:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:40816 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728628AbgEHMnN (ORCPT ); Fri, 8 May 2020 08:43:13 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 91ED820731; Fri, 8 May 2020 12:43:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588941793; bh=D8sLH2taGBH1jwEvqLtqvnEN3ghJ4DGfw4UH7oD9zHY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=n50cmSzH/hl11arDxOaP0RmSCRH3NXcEtbH4kIaCsiBs5F3J25cBdIJMjT+q3MTjq pmtAXaB1skP3OgL7FHmXWPpEAqWVHNcQll7Sv0AfyKJuSsxv2nlpO2eFeVA9lvUmVm /37oDNiHHQN1runGMj0B9P7037F3tjPc0WaCKTfA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Kalle Valo Subject: [PATCH 4.4 173/312] ath9k_htc: check for underflow in ath9k_htc_rx_msg() Date: Fri, 8 May 2020 14:32:44 +0200 Message-Id: <20200508123136.666797570@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200508123124.574959822@linuxfoundation.org> References: <20200508123124.574959822@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Dan Carpenter commit 3a318426e09a9c9266fe6440842e11238f640a20 upstream. We check for overflow here, but we don't check for underflow so it causes a static checker warning. Fixes: fb9987d0f748 ('ath9k_htc: Support for AR9271 chipset.') Signed-off-by: Dan Carpenter Signed-off-by: Kalle Valo Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/ath/ath9k/htc_hst.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wireless/ath/ath9k/htc_hst.c +++ b/drivers/net/wireless/ath/ath9k/htc_hst.c @@ -414,7 +414,7 @@ void ath9k_htc_rx_msg(struct htc_target return; } - if (epid >= ENDPOINT_MAX) { + if (epid < 0 || epid >= ENDPOINT_MAX) { if (pipe_id != USB_REG_IN_PIPE) dev_kfree_skb_any(skb); else