From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C73CDC47247 for ; Fri, 8 May 2020 13:13:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C23324999 for ; Fri, 8 May 2020 13:13:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588943610; bh=3x4YvyiJI3iSiS8ZYzwqW7VtbS7yPmj7iAdexXHtaqI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=zDKXfEx/p4p4r0peqEhvsfAjZew3SasQvU4eSbw/D9T8LgREyYf0h7Qvxo5TiJhXv 3t6bqTjTWY3fk2gkOgL7xt/s7SRJlNrmq8BP8803CY4RXktzLBWVs71JNjsuIdvuzB dNy+qK6NlonUFPMDYOF+foOg8KWGRwow2mkD0Qso= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728740AbgEHNN3 (ORCPT ); Fri, 8 May 2020 09:13:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:50836 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729594AbgEHMrt (ORCPT ); Fri, 8 May 2020 08:47:49 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7CFD021473; Fri, 8 May 2020 12:47:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588942069; bh=3x4YvyiJI3iSiS8ZYzwqW7VtbS7yPmj7iAdexXHtaqI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=j+8rZm4r/aRe6tYKp6k9njEtGnZuiP55PtSoCxMr/aj3/5Cz6YznPZfUtw5F8JIAH eU8eeekv51dHbI8vBVUCI4uwaDRQli8i+6JMUIpAxoX4/sLF7pG5KNl8Tqa7fNSP/j 9jR4XHG40eGFmUDX/Iyw3fOmTBRb/p1MF5rHypwE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Krzysztof Kozlowski , Herbert Xu Subject: [PATCH 4.4 285/312] hwrng: exynos - Disable runtime PM on driver unbind Date: Fri, 8 May 2020 14:34:36 +0200 Message-Id: <20200508123144.443758651@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200508123124.574959822@linuxfoundation.org> References: <20200508123124.574959822@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Krzysztof Kozlowski commit 27d80fa8bccf8d28bef4f89709638efc624fef9a upstream. Driver enabled runtime PM but did not revert this on removal. Re-binding of a device triggered warning: exynos-rng 10830400.rng: Unbalanced pm_runtime_enable! Fixes: b329669ea0b5 ("hwrng: exynos - Add support for Exynos random number generator") Signed-off-by: Krzysztof Kozlowski Signed-off-by: Herbert Xu Signed-off-by: Greg Kroah-Hartman --- drivers/char/hw_random/exynos-rng.c | 9 +++++++++ 1 file changed, 9 insertions(+) --- a/drivers/char/hw_random/exynos-rng.c +++ b/drivers/char/hw_random/exynos-rng.c @@ -155,6 +155,14 @@ static int exynos_rng_probe(struct platf return ret; } +static int exynos_rng_remove(struct platform_device *pdev) +{ + pm_runtime_dont_use_autosuspend(&pdev->dev); + pm_runtime_disable(&pdev->dev); + + return 0; +} + static int __maybe_unused exynos_rng_runtime_suspend(struct device *dev) { struct platform_device *pdev = to_platform_device(dev); @@ -212,6 +220,7 @@ static struct platform_driver exynos_rng .of_match_table = exynos_rng_dt_match, }, .probe = exynos_rng_probe, + .remove = exynos_rng_remove, }; module_platform_driver(exynos_rng_driver);