From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C0DCC54E4B for ; Tue, 12 May 2020 06:02:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A56720746 for ; Tue, 12 May 2020 06:02:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589263353; bh=ZM6NpbvOfmNNVIasGwwWmLWrwf50JY2C08LxJCgUMH4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=m5htAnQ8MYp1h9IDHWDs9WkrfcyonSnelZI9TPacaJccIGuNHP1Rzvdjpq9paSwCq jTgY8EYdf2yfbG9MThJWPJ2QxlSDGesNU+Cbvj+mhl+ZBVjNOay4ksSDxKU/dZyea0 FwamwcpJEYkyzH0parIzNGq0diAwpO27976wt8n8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726891AbgELGCc (ORCPT ); Tue, 12 May 2020 02:02:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:57176 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726161AbgELGCc (ORCPT ); Tue, 12 May 2020 02:02:32 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A017F2072B; Tue, 12 May 2020 06:02:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589263352; bh=ZM6NpbvOfmNNVIasGwwWmLWrwf50JY2C08LxJCgUMH4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R2Habxsh1A7W2vVdTlgZm4eUPJOukvTeexNtzGOfdWD4JQ22BxYHmQGZtGD6cpkCc 8oXKyc7iXorwuqAeD2fCHgqHjAtPu/QsN4qWq7oC4+HrZqd6cTdh5xJNXh47SPRayF aHyXQcR2zYmThaEb/usTwmfQiHXg7YhOiXGokL1M= Date: Tue, 12 May 2020 09:02:28 +0300 From: Leon Romanovsky To: Dennis Dalessandro Cc: jgg@ziepe.ca, dledford@redhat.com, linux-rdma@vger.kernel.org, Mike Marciniszyn , stable@vger.kernel.org, Kaike Wan Subject: Re: [PATCH for-rc or next 3/3] IB/qib: Call kobject_put() when kobject_init_and_add() fails Message-ID: <20200512060228.GC4814@unreal> References: <20200512030622.189865.65024.stgit@awfm-01.aw.intel.com> <20200512031328.189865.48627.stgit@awfm-01.aw.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200512031328.189865.48627.stgit@awfm-01.aw.intel.com> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, May 11, 2020 at 11:13:28PM -0400, Dennis Dalessandro wrote: > From: Kaike Wan > > When kobject_init_and_add() returns an error in the function > qib_create_port_files(), the function kobject_put() is not called for > the corresponding kobject, which potentially leads to memory leak. > > This patch fixes the issue by calling kobject_put() even if > kobject_init_and_add() fails. In addition, the ppd->diagc_kobj is > released along with other kobjects when the sysfs is unregistered. > > Fixes: f931551bafe1 ("IB/qib: Add new qib driver for QLogic PCIe InfiniBand adapters") > Cc: > Suggested-by: Lin Yi > Reviewed-by: Mike Marciniszyn > Signed-off-by: Kaike Wan > Signed-off-by: Dennis Dalessandro > --- > drivers/infiniband/hw/qib/qib_sysfs.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > It is not "even if", the kobject_put() must be called if kobject_init_and_add() fails. Thanks, Reviewed-by: Leon Romanovsky