* Re: [PATCH] ext4: Don't set dioread_nolock by default for blocksize < pagesize [not found] ` <20200329021728.GI53396@mit.edu> @ 2020-05-11 8:07 ` Ritesh Harjani 2020-05-12 11:45 ` Greg KH 0 siblings, 1 reply; 6+ messages in thread From: Ritesh Harjani @ 2020-05-11 8:07 UTC (permalink / raw) To: stable Cc: Theodore Y. Ts'o, linux-ext4, Jan Kara, Aneesh Kumar K . V, Sasha Levin Hello stable-list, I think this subjected patch [1] missed the below fixes tag. I guess the subjected patch is only picked for 5.7. And AFAIU, this patch will be needed for 5.6 as well. Could you please do the needful. Fixes: 244adf6426ee31a (ext4: make dioread_nolock the default) [1]: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git/commit/?h=dev&id=626b035b816b61a7a7b4d2205a6807e2f11a18c1 -ritesh On 3/29/20 7:47 AM, Theodore Y. Ts'o wrote: > On Sat, Mar 28, 2020 at 01:37:44AM +0530, Ritesh Harjani wrote: >> Currently on calling echo 3 > drop_caches on host machine, we see >> FS corruption in the guest. This happens on Power machine where >> blocksize < pagesize. >> >> So as a temporary workaound don't enable dioread_nolock by default >> for blocksize < pagesize until we identify the root cause. >> >> Also emit a warning msg in case if this mount option is manually >> enabled for blocksize < pagesize. >> >> Reported-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> >> Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com> > > Thanks, applied. > > - Ted > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ext4: Don't set dioread_nolock by default for blocksize < pagesize 2020-05-11 8:07 ` [PATCH] ext4: Don't set dioread_nolock by default for blocksize < pagesize Ritesh Harjani @ 2020-05-12 11:45 ` Greg KH 2020-05-12 12:50 ` Ritesh Harjani 0 siblings, 1 reply; 6+ messages in thread From: Greg KH @ 2020-05-12 11:45 UTC (permalink / raw) To: Ritesh Harjani Cc: stable, Theodore Y. Ts'o, linux-ext4, Jan Kara, Aneesh Kumar K . V, Sasha Levin On Mon, May 11, 2020 at 01:37:59PM +0530, Ritesh Harjani wrote: > Hello stable-list, > > I think this subjected patch [1] missed the below fixes tag. > I guess the subjected patch is only picked for 5.7. And > AFAIU, this patch will be needed for 5.6 as well. > > Could you please do the needful. > > Fixes: 244adf6426ee31a (ext4: make dioread_nolock the default) > > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git/commit/?h=dev&id=626b035b816b61a7a7b4d2205a6807e2f11a18c1 This patch does not apply to the 5.6 kernel tree at all. Please provide a working backport if you wish to see it present there. thanks, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ext4: Don't set dioread_nolock by default for blocksize < pagesize 2020-05-12 11:45 ` Greg KH @ 2020-05-12 12:50 ` Ritesh Harjani 2020-05-12 12:59 ` Greg KH 0 siblings, 1 reply; 6+ messages in thread From: Ritesh Harjani @ 2020-05-12 12:50 UTC (permalink / raw) To: Greg KH Cc: stable, Theodore Y. Ts'o, linux-ext4, Jan Kara, Aneesh Kumar K . V, Sasha Levin Hello Greg, On 5/12/20 5:15 PM, Greg KH wrote: > On Mon, May 11, 2020 at 01:37:59PM +0530, Ritesh Harjani wrote: >> Hello stable-list, >> >> I think this subjected patch [1] missed the below fixes tag. >> I guess the subjected patch is only picked for 5.7. And >> AFAIU, this patch will be needed for 5.6 as well. >> >> Could you please do the needful. >> >> Fixes: 244adf6426ee31a (ext4: make dioread_nolock the default) >> >> [1]: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git/commit/?h=dev&id=626b035b816b61a7a7b4d2205a6807e2f11a18c1 > > This patch does not apply to the 5.6 kernel tree at all. Please provide > a working backport if you wish to see it present there. Sorry if that's the case. I tried both "git cherry-pick" and "git am" with patch mentioned @ [1] to apply on branch "remotes/linux-stable/linux-5.6.y" of tree https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git and it applied cleanly. Also, just noticed this patch in the queue. Is it that maybe you are trying to apply it twice? https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-5.6/ext4-don-t-set-dioread_nolock-by-default-for-blocksi.patch Do let me know if I am missing anything here. -ritesh ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ext4: Don't set dioread_nolock by default for blocksize < pagesize 2020-05-12 12:50 ` Ritesh Harjani @ 2020-05-12 12:59 ` Greg KH 2020-05-12 14:13 ` Sasha Levin 0 siblings, 1 reply; 6+ messages in thread From: Greg KH @ 2020-05-12 12:59 UTC (permalink / raw) To: Ritesh Harjani Cc: stable, Theodore Y. Ts'o, linux-ext4, Jan Kara, Aneesh Kumar K . V, Sasha Levin On Tue, May 12, 2020 at 06:20:05PM +0530, Ritesh Harjani wrote: > Hello Greg, > > On 5/12/20 5:15 PM, Greg KH wrote: > > On Mon, May 11, 2020 at 01:37:59PM +0530, Ritesh Harjani wrote: > > > Hello stable-list, > > > > > > I think this subjected patch [1] missed the below fixes tag. > > > I guess the subjected patch is only picked for 5.7. And > > > AFAIU, this patch will be needed for 5.6 as well. > > > > > > Could you please do the needful. > > > > > > Fixes: 244adf6426ee31a (ext4: make dioread_nolock the default) > > > > > > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git/commit/?h=dev&id=626b035b816b61a7a7b4d2205a6807e2f11a18c1 > > > > This patch does not apply to the 5.6 kernel tree at all. Please provide > > a working backport if you wish to see it present there. > > Sorry if that's the case. > I tried both "git cherry-pick" and "git am" with patch mentioned @ [1] > to apply on branch "remotes/linux-stable/linux-5.6.y" of tree > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git > and it applied cleanly. > > Also, just noticed this patch in the queue. Is it that maybe you are > trying to apply it twice? > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-5.6/ext4-don-t-set-dioread_nolock-by-default-for-blocksi.patch Odd, it didn't have the "upstream" commit id, which is why I didn't see that it was applied already. Sasha, something went wrong with your scripts, you didn't sign-off on it either :( greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ext4: Don't set dioread_nolock by default for blocksize < pagesize 2020-05-12 12:59 ` Greg KH @ 2020-05-12 14:13 ` Sasha Levin 2020-05-12 16:12 ` Greg KH 0 siblings, 1 reply; 6+ messages in thread From: Sasha Levin @ 2020-05-12 14:13 UTC (permalink / raw) To: Greg KH Cc: Ritesh Harjani, stable, Theodore Y. Ts'o, linux-ext4, Jan Kara, Aneesh Kumar K . V On Tue, May 12, 2020 at 02:59:31PM +0200, Greg KH wrote: >On Tue, May 12, 2020 at 06:20:05PM +0530, Ritesh Harjani wrote: >> Hello Greg, >> >> On 5/12/20 5:15 PM, Greg KH wrote: >> > On Mon, May 11, 2020 at 01:37:59PM +0530, Ritesh Harjani wrote: >> > > Hello stable-list, >> > > >> > > I think this subjected patch [1] missed the below fixes tag. >> > > I guess the subjected patch is only picked for 5.7. And >> > > AFAIU, this patch will be needed for 5.6 as well. >> > > >> > > Could you please do the needful. >> > > >> > > Fixes: 244adf6426ee31a (ext4: make dioread_nolock the default) >> > > >> > > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git/commit/?h=dev&id=626b035b816b61a7a7b4d2205a6807e2f11a18c1 >> > >> > This patch does not apply to the 5.6 kernel tree at all. Please provide >> > a working backport if you wish to see it present there. >> >> Sorry if that's the case. >> I tried both "git cherry-pick" and "git am" with patch mentioned @ [1] >> to apply on branch "remotes/linux-stable/linux-5.6.y" of tree >> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git >> and it applied cleanly. >> >> Also, just noticed this patch in the queue. Is it that maybe you are >> trying to apply it twice? >> >> https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-5.6/ext4-don-t-set-dioread_nolock-by-default-for-blocksi.patch > >Odd, it didn't have the "upstream" commit id, which is why I didn't see >that it was applied already. > >Sasha, something went wrong with your scripts, you didn't sign-off on it >either :( Crap, sorry. I'll fix it up. I'm testing out a new script that integrates the dependency mappings I have with the rest of the script, and it looks like there are some quirks I need to deal with. -- Thanks, Sasha ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ext4: Don't set dioread_nolock by default for blocksize < pagesize 2020-05-12 14:13 ` Sasha Levin @ 2020-05-12 16:12 ` Greg KH 0 siblings, 0 replies; 6+ messages in thread From: Greg KH @ 2020-05-12 16:12 UTC (permalink / raw) To: Sasha Levin Cc: Ritesh Harjani, stable, Theodore Y. Ts'o, linux-ext4, Jan Kara, Aneesh Kumar K . V On Tue, May 12, 2020 at 10:13:12AM -0400, Sasha Levin wrote: > On Tue, May 12, 2020 at 02:59:31PM +0200, Greg KH wrote: > > On Tue, May 12, 2020 at 06:20:05PM +0530, Ritesh Harjani wrote: > > > Hello Greg, > > > > > > On 5/12/20 5:15 PM, Greg KH wrote: > > > > On Mon, May 11, 2020 at 01:37:59PM +0530, Ritesh Harjani wrote: > > > > > Hello stable-list, > > > > > > > > > > I think this subjected patch [1] missed the below fixes tag. > > > > > I guess the subjected patch is only picked for 5.7. And > > > > > AFAIU, this patch will be needed for 5.6 as well. > > > > > > > > > > Could you please do the needful. > > > > > > > > > > Fixes: 244adf6426ee31a (ext4: make dioread_nolock the default) > > > > > > > > > > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git/commit/?h=dev&id=626b035b816b61a7a7b4d2205a6807e2f11a18c1 > > > > > > > > This patch does not apply to the 5.6 kernel tree at all. Please provide > > > > a working backport if you wish to see it present there. > > > > > > Sorry if that's the case. > > > I tried both "git cherry-pick" and "git am" with patch mentioned @ [1] > > > to apply on branch "remotes/linux-stable/linux-5.6.y" of tree > > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git > > > and it applied cleanly. > > > > > > Also, just noticed this patch in the queue. Is it that maybe you are > > > trying to apply it twice? > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-5.6/ext4-don-t-set-dioread_nolock-by-default-for-blocksi.patch > > > > Odd, it didn't have the "upstream" commit id, which is why I didn't see > > that it was applied already. > > > > Sasha, something went wrong with your scripts, you didn't sign-off on it > > either :( > > Crap, sorry. I'll fix it up. I already did :) ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-12 16:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <87pndagw7s.fsf@linux.ibm.com>
[not found] ` <20200327200744.12473-1-riteshh@linux.ibm.com>
[not found] ` <20200329021728.GI53396@mit.edu>
2020-05-11 8:07 ` [PATCH] ext4: Don't set dioread_nolock by default for blocksize < pagesize Ritesh Harjani
2020-05-12 11:45 ` Greg KH
2020-05-12 12:50 ` Ritesh Harjani
2020-05-12 12:59 ` Greg KH
2020-05-12 14:13 ` Sasha Levin
2020-05-12 16:12 ` Greg KH
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).