stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: stable@vger.kernel.org,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Stephen Boyd <sboyd@codeaurora.org>
Subject: Re: [PATCH 4.4 06/16] clk: Fix debugfs_create_*() usage
Date: Wed, 13 May 2020 11:37:03 +0200	[thread overview]
Message-ID: <20200513093703.GE830571@kroah.com> (raw)
In-Reply-To: <20200423204014.784944-7-lee.jones@linaro.org>

On Thu, Apr 23, 2020 at 09:40:04PM +0100, Lee Jones wrote:
> From: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> [ Upstream commit 4c8326d5ebb0de3191e98980c80ab644026728d0 ]
> 
> When exposing data access through debugfs, the correct
> debugfs_create_*() functions must be used, matching the data
> types.
> 
> Remove all casts from data pointers passed to debugfs_create_*()
> functions, as such casts prevent the compiler from flagging bugs.
> 
> clk_core.rate and .accuracy are "unsigned long", hence casting
> their addresses to "u32 *" exposed the wrong halves on big-endian
> 64-bit systems. Fix this by using debugfs_create_ulong() instead.
> 
> Octal permissions are preferred, as they are easier to read than
> symbolic permissions. Hence replace "S_IRUGO" by "0444"
> throughout.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> [sboyd@codeaurora.org: Squash the octal change in too]
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/clk/clk.c | 30 ++++++++++++++----------------
>  1 file changed, 14 insertions(+), 16 deletions(-)

What about 4.9?

I'm going to stop here and wait for a fixed up series of this, and any
newer kernels that need the patches as well.

thanks,

greg k-h

  reply	other threads:[~2020-05-13  9:37 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-23 20:39 [PATCH 4.4 00/16] Backported fixes taken from Sony's Vendor tree Lee Jones
2020-04-23 20:39 ` [PATCH 4.4 01/16] drm/msm: stop abusing dma_map/unmap for cache Lee Jones
2020-04-23 20:40 ` [PATCH 4.4 02/16] gpiolib: Fix references to gpiod_[gs]et_*value_cansleep() variants Lee Jones
2020-05-13  9:34   ` Greg KH
2020-05-18 10:23   ` [PATCH 4.4 02/16 (v2)] " Lee Jones
2020-04-23 20:40 ` [PATCH 4.4 03/16] devres: Align data[] to ARCH_KMALLOC_MINALIGN Lee Jones
2020-05-13  9:35   ` Greg Kroah-Hartman
2020-05-13  9:48     ` Geert Uytterhoeven
2020-05-13 10:10       ` David Laight
2020-05-13 11:05         ` Geert Uytterhoeven
2020-05-13 11:06           ` Geert Uytterhoeven
2020-05-13 12:37             ` David Laight
2020-05-13 13:26               ` Geert Uytterhoeven
2020-05-13 13:35                 ` David Laight
2020-05-13 13:36         ` Peter Zijlstra
2020-05-13 13:50           ` David Laight
2020-04-23 20:40 ` [PATCH 4.4 04/16] crypto: talitos - Delete an error message for a failed memory allocation in talitos_edesc_alloc() Lee Jones
2020-05-13  9:36   ` Greg KH
2020-05-18 10:17     ` Lee Jones
2020-04-23 20:40 ` [PATCH 4.4 05/16] drm: NULL pointer dereference [null-pointer-deref] (CWE 476) problem Lee Jones
2020-05-13  9:36   ` Greg KH
2020-04-23 20:40 ` [PATCH 4.4 06/16] clk: Fix debugfs_create_*() usage Lee Jones
2020-05-13  9:37   ` Greg KH [this message]
2020-05-18 10:08     ` Lee Jones
2020-04-23 20:40 ` [PATCH 4.4 07/16] arm64: traps: Don't print stack or raw PC/LR values in backtraces Lee Jones
2020-04-23 20:40 ` [PATCH 4.4 08/16] serial/sunsu: add missing of_node_put() Lee Jones
2020-05-06  8:23   ` Greg Kroah-Hartman
2020-05-06  9:02     ` Lee Jones
2020-04-23 20:40 ` [PATCH 4.4 09/16] wil6210: increase firmware ready timeout Lee Jones
2020-04-23 20:40 ` [PATCH 4.4 10/16] wil6210: fix temperature debugfs Lee Jones
2020-04-23 20:40 ` [PATCH 4.4 11/16] scsi: ufs: ufs-qcom: remove broken hci version quirk Lee Jones
2020-04-23 20:40 ` [PATCH 4.4 12/16] wil6210: rate limit wil_rx_refill error Lee Jones
2020-04-23 20:40 ` [PATCH 4.4 13/16] rtc: pm8xxx: Fix issue in RTC write path Lee Jones
2020-04-23 20:40 ` [PATCH 4.4 14/16] soc: qcom: smem: Use le32_to_cpu for comparison Lee Jones
2020-04-23 20:40 ` [PATCH 4.4 15/16] of: fix missing kobject init for !SYSFS && OF_DYNAMIC config Lee Jones
2020-04-23 20:40 ` [PATCH 4.4 16/16] mm/vmalloc.c: move 'area->pages' after if statement Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200513093703.GE830571@kroah.com \
    --to=greg@kroah.com \
    --cc=geert+renesas@glider.be \
    --cc=lee.jones@linaro.org \
    --cc=sboyd@codeaurora.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).