From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C78D8CA90AF for ; Wed, 13 May 2020 09:54:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C6B520769 for ; Wed, 13 May 2020 09:54:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589363656; bh=TROMNritinLe8dzAlxtqwygDZ6dgPrhrcQC19NPq7Ng=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=u1Gw26WaIhvIBOel5p4OwF5O9EL4gxvz9UpG5NwuKhnKvWsXBsceb8fuEGKmCUrHC CB4gLOrDP4fMabNjNd7AU4cjrcrEPVvSsG0qr8026WOEAW5FLMmQ++5TEadfoCUgZT a5MEKKpMRQA/89uNZrs3IPX+KYfgm0R19zHQF7Qk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388074AbgEMJyP (ORCPT ); Wed, 13 May 2020 05:54:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:56548 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387419AbgEMJyO (ORCPT ); Wed, 13 May 2020 05:54:14 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4425720575; Wed, 13 May 2020 09:54:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589363653; bh=TROMNritinLe8dzAlxtqwygDZ6dgPrhrcQC19NPq7Ng=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=s1GBZDIb/555dttbuZRzGTTJ8iWsYQ3CGz+tkXKePcEyGESucCxqfNA5m08z0SJjE mGo1jSZZIyoMD+ghJbrhaxqAPNPu0gnkGG8p7rsjeYo9mVN72/TY81qUHI6GTG1CXE c8YCrY0YMxhozRDZNAkmTL/B7g2hdXrP/1Vv9UKo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andy Shevchenko , Yash Shah , Nicolas Ferre , Dejin Zheng , "David S. Miller" Subject: [PATCH 5.6 024/118] net: macb: fix an issue about leak related system resources Date: Wed, 13 May 2020 11:44:03 +0200 Message-Id: <20200513094419.792889814@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200513094417.618129545@linuxfoundation.org> References: <20200513094417.618129545@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Dejin Zheng [ Upstream commit b959c77dac09348955f344104c6a921ebe104753 ] A call of the function macb_init() can fail in the function fu540_c000_init. The related system resources were not released then. use devm_platform_ioremap_resource() to replace ioremap() to fix it. Fixes: c218ad559020ff9 ("macb: Add support for SiFive FU540-C000") Cc: Andy Shevchenko Reviewed-by: Yash Shah Suggested-by: Nicolas Ferre Suggested-by: Andy Shevchenko Signed-off-by: Dejin Zheng Acked-by: Nicolas Ferre Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/cadence/macb_main.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -4165,15 +4165,9 @@ static int fu540_c000_clk_init(struct pl static int fu540_c000_init(struct platform_device *pdev) { - struct resource *res; - - res = platform_get_resource(pdev, IORESOURCE_MEM, 1); - if (!res) - return -ENODEV; - - mgmt->reg = ioremap(res->start, resource_size(res)); - if (!mgmt->reg) - return -ENOMEM; + mgmt->reg = devm_platform_ioremap_resource(pdev, 1); + if (IS_ERR(mgmt->reg)) + return PTR_ERR(mgmt->reg); return macb_init(pdev); }