Re: [PATCH 4.4 06/16] clk: Fix debugfs_create_*() usage

[Lee Jones <lee.jones@linaro.org>]

On Wed, 13 May 2020, Greg KH wrote:

> On Thu, Apr 23, 2020 at 09:40:04PM +0100, Lee Jones wrote:
> > From: Geert Uytterhoeven <geert+renesas@glider.be>
> > 
> > [ Upstream commit 4c8326d5ebb0de3191e98980c80ab644026728d0 ]
> > 
> > When exposing data access through debugfs, the correct
> > debugfs_create_*() functions must be used, matching the data
> > types.
> > 
> > Remove all casts from data pointers passed to debugfs_create_*()
> > functions, as such casts prevent the compiler from flagging bugs.
> > 
> > clk_core.rate and .accuracy are "unsigned long", hence casting
> > their addresses to "u32 *" exposed the wrong halves on big-endian
> > 64-bit systems. Fix this by using debugfs_create_ulong() instead.
> > 
> > Octal permissions are preferred, as they are easier to read than
> > symbolic permissions. Hence replace "S_IRUGO" by "0444"
> > throughout.
> > 
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > [sboyd@codeaurora.org: Squash the octal change in too]
> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> >  drivers/clk/clk.c | 30 ++++++++++++++----------------
> >  1 file changed, 14 insertions(+), 16 deletions(-)
> 
> What about 4.9?

I sent this for v4.9 on the 22nd April.

https://www.spinics.net/lists/stable/msg382001.html

> I'm going to stop here and wait for a fixed up series of this, and any
> newer kernels that need the patches as well.
> 
> thanks,
> 
> greg k-h

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog