From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B4AAC433DF for ; Mon, 18 May 2020 18:27:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 36BCA2065F for ; Mon, 18 May 2020 18:27:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589826470; bh=WnNstYCDUFAAXrsF4FoTE8vpCGvT/AX729NNv95uTrM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=b+n2LSV3WPxAqgomr64S5ishqtSdQTtUKlG27VCT2xBWT9LbrxdgJTmFxnAwO6kYQ nQh1sb5Al30mlIDWx9xekmx7axD/L0CgfdNTFWLH3YJWi8wNrSRnJaoX4TXLEWdiyg OPQWBSkOPvXuUju55GO1udyvaTiwjAe1itd97Scg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729645AbgERS1p (ORCPT ); Mon, 18 May 2020 14:27:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:41526 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729622AbgERRnn (ORCPT ); Mon, 18 May 2020 13:43:43 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D217120878; Mon, 18 May 2020 17:43:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589823823; bh=WnNstYCDUFAAXrsF4FoTE8vpCGvT/AX729NNv95uTrM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zm2NGDVHbYGLJ6hSvbPxvwdIFS7cVSgMbHry9opkzg5oxZrgy4Vylttq/scl8/Blj Zv6h50snV7YAr6jtRHP+K/pX+/uG5J2gJ4EBpUNH26C15KADXEhp/N82SXzOVMBN2+ ecdLScoD91MKvyM3mV31/CDkFoYE+O4lFDmnmpMI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lubomir Rintel , Vinod Koul , Sasha Levin Subject: [PATCH 4.9 50/90] dmaengine: mmp_tdma: Reset channel error on release Date: Mon, 18 May 2020 19:36:28 +0200 Message-Id: <20200518173501.371239098@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200518173450.930655662@linuxfoundation.org> References: <20200518173450.930655662@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Lubomir Rintel [ Upstream commit 0c89446379218698189a47871336cb30286a7197 ] When a channel configuration fails, the status of the channel is set to DEV_ERROR so that an attempt to submit it fails. However, this status sticks until the heat end of the universe, making it impossible to recover from the error. Let's reset it when the channel is released so that further use of the channel with correct configuration is not impacted. Signed-off-by: Lubomir Rintel Link: https://lore.kernel.org/r/20200419164912.670973-5-lkundrak@v3.sk Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/mmp_tdma.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/dma/mmp_tdma.c b/drivers/dma/mmp_tdma.c index 13c68b6434ce2..15b4a44e60069 100644 --- a/drivers/dma/mmp_tdma.c +++ b/drivers/dma/mmp_tdma.c @@ -362,6 +362,8 @@ static void mmp_tdma_free_descriptor(struct mmp_tdma_chan *tdmac) gen_pool_free(gpool, (unsigned long)tdmac->desc_arr, size); tdmac->desc_arr = NULL; + if (tdmac->status == DMA_ERROR) + tdmac->status = DMA_COMPLETE; return; } -- 2.20.1