From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98641C433E1 for ; Mon, 18 May 2020 18:26:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 71B3F207C4 for ; Mon, 18 May 2020 18:26:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589826365; bh=Zl0uOgz7VZUw9aDWIujEZjYk+KwhoWX6LHcHCVTFqcg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=zEdGMrQH5gwFKmqkBZqn9jnJRtL7AkXqqa6cDg82mJdLicOgFlYcZHUEvhmTHgXsq e1PeWGNjABDK3oZmnvwm5F27V8UdLT0SwEKq30qZfFOCwseygGjkZJMZthTRCRKgEy rnQPRNDpAVbuNF5gp6Uy0tdCLeQ24bNEtQr6cgzk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730002AbgERRpu (ORCPT ); Mon, 18 May 2020 13:45:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:45044 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729998AbgERRpu (ORCPT ); Mon, 18 May 2020 13:45:50 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4820720671; Mon, 18 May 2020 17:45:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589823949; bh=Zl0uOgz7VZUw9aDWIujEZjYk+KwhoWX6LHcHCVTFqcg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FlwcsDUeHHFDIgBG10Y7rZLFe3CeXxtMT0isCF15pex1nw8ggi8Dn7/PYbHiju2Dd DXoqkCKH4c9soe8YvyNA2cy8Gr3BsB08lUJYp8r4UuLte1KDoVNCvCMM6JuCAwFrRs oIggZyOup3Qqf+uhr4dKyVuOTjZQCWniLG/X8KNY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Moshe Shemesh , Eran Ben Elisha , Saeed Mahameed Subject: [PATCH 4.14 011/114] net/mlx5: Fix command entry leak in Internal Error State Date: Mon, 18 May 2020 19:35:43 +0200 Message-Id: <20200518173505.410713690@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200518173503.033975649@linuxfoundation.org> References: <20200518173503.033975649@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Moshe Shemesh [ Upstream commit cece6f432cca9f18900463ed01b97a152a03600a ] Processing commands by cmd_work_handler() while already in Internal Error State will result in entry leak, since the handler process force completion without doorbell. Forced completion doesn't release the entry and event completion will never arrive, so entry should be released. Fixes: 73dd3a4839c1 ("net/mlx5: Avoid using pending command interface slots") Signed-off-by: Moshe Shemesh Signed-off-by: Eran Ben Elisha Signed-off-by: Saeed Mahameed Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c @@ -865,6 +865,10 @@ static void cmd_work_handler(struct work MLX5_SET(mbox_out, ent->out, syndrome, drv_synd); mlx5_cmd_comp_handler(dev, 1UL << ent->idx, true); + /* no doorbell, no need to keep the entry */ + free_ent(cmd, ent->idx); + if (ent->callback) + free_cmd(ent); return; }