From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98FB1C433E1 for ; Mon, 18 May 2020 17:46:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 71B7220715 for ; Mon, 18 May 2020 17:46:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589824011; bh=elBqDTYUwnIKKlx+yy0o5O7JNMP5I8Jusy8PmsFLkcI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=IiNXraV4iE+t/9JPCAeOZV6wjZb2fQ/3B3XF27wla13ZH3PLprkz9CxHCPM9nhqay 8B5iVET9Z4juMXS+v59PZnYEZwsY/HwAx4JTSi4Vzrd0bQmRF105tiK89wzm3b+xZ+ Oxwdb5CI+LtkOhOHrsUeDafmbRJMC1C4OVB+xZxk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729934AbgERRqu (ORCPT ); Mon, 18 May 2020 13:46:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:46762 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730137AbgERRqt (ORCPT ); Mon, 18 May 2020 13:46:49 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2C14D20674; Mon, 18 May 2020 17:46:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589824008; bh=elBqDTYUwnIKKlx+yy0o5O7JNMP5I8Jusy8PmsFLkcI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l2987zsXGc+POC3oRkA44dyZXk2oVLmfHgTLZdtu8uFlQJfCcEtu1qjmwpM8OBorw m7EGrJAg6f9CiQu4x+MLY/V3RFyLRNS3f8AcUT9cGwz4fV7oxz+y1Vh4BN/XLUiCEy HbhBFr0fqVHRRW2bUhnCmpnvOnOx6pQVOSaD4F2Q= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miroslav Benes , Josh Poimboeuf , Ingo Molnar , Andy Lutomirski , Dave Jones , Jann Horn , Peter Zijlstra , Thomas Gleixner , Vince Weaver Subject: [PATCH 4.14 033/114] x86/unwind/orc: Fix error path for bad ORC entry type Date: Mon, 18 May 2020 19:36:05 +0200 Message-Id: <20200518173509.665006980@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200518173503.033975649@linuxfoundation.org> References: <20200518173503.033975649@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Josh Poimboeuf commit a0f81bf26888048100bf017fadf438a5bdffa8d8 upstream. If the ORC entry type is unknown, nothing else can be done other than reporting an error. Exit the function instead of breaking out of the switch statement. Fixes: ee9f8fce9964 ("x86/unwind: Add the ORC unwinder") Reviewed-by: Miroslav Benes Signed-off-by: Josh Poimboeuf Signed-off-by: Ingo Molnar Cc: Andy Lutomirski Cc: Dave Jones Cc: Jann Horn Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Vince Weaver Link: https://lore.kernel.org/r/a7fa668ca6eabbe81ab18b2424f15adbbfdc810a.1587808742.git.jpoimboe@redhat.com Signed-off-by: Greg Kroah-Hartman --- arch/x86/kernel/unwind_orc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/x86/kernel/unwind_orc.c +++ b/arch/x86/kernel/unwind_orc.c @@ -457,7 +457,7 @@ bool unwind_next_frame(struct unwind_sta default: orc_warn("unknown .orc_unwind entry type %d for ip %pB\n", orc->type, (void *)orig_ip); - break; + goto done; } /* Find BP: */