From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51D82C433E0 for ; Tue, 19 May 2020 07:17:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 28DB12070A for ; Tue, 19 May 2020 07:17:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728286AbgESHRJ (ORCPT ); Tue, 19 May 2020 03:17:09 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:45666 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726892AbgESHRJ (ORCPT ); Tue, 19 May 2020 03:17:09 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id E31491C025C; Tue, 19 May 2020 09:17:07 +0200 (CEST) Date: Tue, 19 May 2020 09:17:07 +0200 From: Pavel Machek To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Florian Fainelli , Andrew Lunn , "David S. Miller" Subject: Re: [PATCH 4.19 01/80] net: dsa: Do not make user port errors fatal Message-ID: <20200519071707.GA2609@amd> References: <20200518173450.097837707@linuxfoundation.org> <20200518173450.419156571@linuxfoundation.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="sdtB3X0nJg68CQEu" Content-Disposition: inline In-Reply-To: <20200518173450.419156571@linuxfoundation.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org --sdtB3X0nJg68CQEu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > From: Florian Fainelli >=20 > commit 86f8b1c01a0a537a73d2996615133be63cdf75db upstream. >=20 > Prior to 1d27732f411d ("net: dsa: setup and teardown ports"), we would > not treat failures to set-up an user port as fatal, but after this > commit we would, which is a regression for some systems where interfaces > may be declared in the Device Tree, but the underlying hardware may not > be present (pluggable daughter cards for instance). >=20 > +++ b/net/dsa/dsa2.c > @@ -412,7 +412,7 @@ static int dsa_tree_setup_switches(struc > =20 > err =3D dsa_switch_setup(ds); > if (err) > - return err; > + continue; The error code is discarded here, so user can now wonder "why does not my port work" with no indications in the logs... Should we do dev_info() here? Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --sdtB3X0nJg68CQEu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl7Dh/MACgkQMOfwapXb+vK6EwCfbsYtW3pWBV0oHAsKPFkjovUR EMwAn0AlL0il0dzKyEclywFJIbeOaWmh =+Ing -----END PGP SIGNATURE----- --sdtB3X0nJg68CQEu--