* [PATCH v3 1/2] mtd: rawnand: brcmnand: fix hamming oob layout [not found] ` <20200512060023.684871-1-noltari@gmail.com> @ 2020-05-12 6:00 ` Álvaro Fernández Rojas 2020-05-19 11:49 ` Sasha Levin [not found] ` <20200512075733.745374-1-noltari@gmail.com> 1 sibling, 1 reply; 5+ messages in thread From: Álvaro Fernández Rojas @ 2020-05-12 6:00 UTC (permalink / raw) To: computersforpeace, kdasu.kdev, miquel.raynal, richard, vigneshr, sumit.semwal, linux-mtd, bcm-kernel-feedback-list, linux-kernel, linux-media, dri-devel, linaro-mm-sig Cc: Álvaro Fernández Rojas, stable First 2 bytes are used in large-page nand. Fixes: ef5eeea6e911 ("mtd: nand: brcm: switch to mtd_ooblayout_ops") Cc: stable@vger.kernel.org Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> --- v3: invert patch order v2: extend original comment drivers/mtd/nand/raw/brcmnand/brcmnand.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c index e4e3ceeac38f..1c1070111ebc 100644 --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c @@ -1116,11 +1116,14 @@ static int brcmnand_hamming_ooblayout_free(struct mtd_info *mtd, int section, if (!section) { /* * Small-page NAND use byte 6 for BBI while large-page - * NAND use byte 0. + * NAND use bytes 0 and 1. */ - if (cfg->page_size > 512) - oobregion->offset++; - oobregion->length--; + if (cfg->page_size > 512) { + oobregion->offset += 2; + oobregion->length -= 2; + } else { + oobregion->length--; + } } } -- 2.26.2 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3 1/2] mtd: rawnand: brcmnand: fix hamming oob layout 2020-05-12 6:00 ` [PATCH v3 1/2] mtd: rawnand: brcmnand: fix hamming oob layout Álvaro Fernández Rojas @ 2020-05-19 11:49 ` Sasha Levin 0 siblings, 0 replies; 5+ messages in thread From: Sasha Levin @ 2020-05-19 11:49 UTC (permalink / raw) To: Sasha Levin, computersforpeace, kdasu.kdev; +Cc: stable, stable Hi [This is an automated email] This commit has been processed because it contains a "Fixes:" tag fixing commit: ef5eeea6e911 ("mtd: nand: brcm: switch to mtd_ooblayout_ops"). The bot has tested the following trees: v5.6.13, v5.4.41, v4.19.123, v4.14.180, v4.9.223. v5.6.13: Build OK! v5.4.41: Build OK! v4.19.123: Build OK! v4.14.180: Failed to apply! Possible dependencies: Unable to calculate v4.9.223: Failed to apply! Possible dependencies: Unable to calculate NOTE: The patch will not be queued to stable trees until it is upstream. How should we proceed with this patch? -- Thanks Sasha ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <20200512075733.745374-1-noltari@gmail.com>]
* [PATCH v4 1/2] mtd: rawnand: brcmnand: fix hamming oob layout [not found] ` <20200512075733.745374-1-noltari@gmail.com> @ 2020-05-12 7:57 ` Álvaro Fernández Rojas 2020-05-19 11:49 ` Sasha Levin 2020-05-24 19:17 ` Miquel Raynal 0 siblings, 2 replies; 5+ messages in thread From: Álvaro Fernández Rojas @ 2020-05-12 7:57 UTC (permalink / raw) To: computersforpeace, kdasu.kdev, miquel.raynal, richard, vigneshr, sumit.semwal, linux-mtd, bcm-kernel-feedback-list, linux-kernel, linux-media, dri-devel, linaro-mm-sig Cc: Álvaro Fernández Rojas, stable First 2 bytes are used in large-page nand. Fixes: ef5eeea6e911 ("mtd: nand: brcm: switch to mtd_ooblayout_ops") Cc: stable@vger.kernel.org Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> --- v4: no changes v3: invert patch order v2: extend original comment drivers/mtd/nand/raw/brcmnand/brcmnand.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c index e4e3ceeac38f..1c1070111ebc 100644 --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c @@ -1116,11 +1116,14 @@ static int brcmnand_hamming_ooblayout_free(struct mtd_info *mtd, int section, if (!section) { /* * Small-page NAND use byte 6 for BBI while large-page - * NAND use byte 0. + * NAND use bytes 0 and 1. */ - if (cfg->page_size > 512) - oobregion->offset++; - oobregion->length--; + if (cfg->page_size > 512) { + oobregion->offset += 2; + oobregion->length -= 2; + } else { + oobregion->length--; + } } } -- 2.26.2 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v4 1/2] mtd: rawnand: brcmnand: fix hamming oob layout 2020-05-12 7:57 ` [PATCH v4 " Álvaro Fernández Rojas @ 2020-05-19 11:49 ` Sasha Levin 2020-05-24 19:17 ` Miquel Raynal 1 sibling, 0 replies; 5+ messages in thread From: Sasha Levin @ 2020-05-19 11:49 UTC (permalink / raw) To: Sasha Levin, computersforpeace, kdasu.kdev; +Cc: stable, stable Hi [This is an automated email] This commit has been processed because it contains a "Fixes:" tag fixing commit: ef5eeea6e911 ("mtd: nand: brcm: switch to mtd_ooblayout_ops"). The bot has tested the following trees: v5.6.13, v5.4.41, v4.19.123, v4.14.180, v4.9.223. v5.6.13: Build OK! v5.4.41: Build OK! v4.19.123: Build OK! v4.14.180: Failed to apply! Possible dependencies: Unable to calculate v4.9.223: Failed to apply! Possible dependencies: Unable to calculate NOTE: The patch will not be queued to stable trees until it is upstream. How should we proceed with this patch? -- Thanks Sasha ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v4 1/2] mtd: rawnand: brcmnand: fix hamming oob layout 2020-05-12 7:57 ` [PATCH v4 " Álvaro Fernández Rojas 2020-05-19 11:49 ` Sasha Levin @ 2020-05-24 19:17 ` Miquel Raynal 1 sibling, 0 replies; 5+ messages in thread From: Miquel Raynal @ 2020-05-24 19:17 UTC (permalink / raw) To: Álvaro Fernández Rojas, computersforpeace, kdasu.kdev, miquel.raynal, richard, vigneshr, sumit.semwal, linux-mtd, bcm-kernel-feedback-list, linux-kernel, linux-media, dri-devel, linaro-mm-sig Cc: stable On Tue, 2020-05-12 at 07:57:32 UTC, =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= wrote: > First 2 bytes are used in large-page nand. > > Fixes: ef5eeea6e911 ("mtd: nand: brcm: switch to mtd_ooblayout_ops") > Cc: stable@vger.kernel.org > Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-24 19:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20200504185945.2776148-1-noltari@gmail.com>
[not found] ` <20200512060023.684871-1-noltari@gmail.com>
2020-05-12 6:00 ` [PATCH v3 1/2] mtd: rawnand: brcmnand: fix hamming oob layout Álvaro Fernández Rojas
2020-05-19 11:49 ` Sasha Levin
[not found] ` <20200512075733.745374-1-noltari@gmail.com>
2020-05-12 7:57 ` [PATCH v4 " Álvaro Fernández Rojas
2020-05-19 11:49 ` Sasha Levin
2020-05-24 19:17 ` Miquel Raynal
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).