From: Sasha Levin <sashal@kernel.org>
To: Ben Hutchings <ben.hutchings@codethink.co.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sasha Levin <Alexander.Levin@microsoft.com>,
stable <stable@vger.kernel.org>
Subject: Re: [stable] i2c: dev: Fix the race between the release of i2c_dev and cdev
Date: Thu, 21 May 2020 19:33:35 -0400 [thread overview]
Message-ID: <20200521233335.GI33628@sasha-vm> (raw)
In-Reply-To: <1d4004d71924fa2e4c422ae086166c280e5b43be.camel@codethink.co.uk>
On Thu, May 21, 2020 at 09:58:57PM +0100, Ben Hutchings wrote:
>On Thu, 2020-05-21 at 07:50 +0200, Greg Kroah-Hartman wrote:
>> On Wed, May 20, 2020 at 08:45:15PM +0100, Ben Hutchings wrote:
>> > Please pick this fix for all stable branches:
>> >
>> > commit 1413ef638abae4ab5621901cf4d8ef08a4a48ba6
>> > Author: Kevin Hao <haokexin@gmail.com>
>> > Date: Fri Oct 11 23:00:14 2019 +0800
>> >
>> > i2c: dev: Fix the race between the release of i2c_dev and cdev
>> >
>> > I don't know whether it will apply cleanly to all of them; I can deal
>> > with those where it doesn't.
>>
>> I applied it to 4.14, 4.19, 5.4, and 5.6. It does apply to 4.9 but as
>> the patch it depends on is not there, I don't think it will help.
>
>It was included in 4.9.224, so both this and the similar watchdog fix
>should be applicable for 4.9.
I took it for 4.9, haven't noticed any issues.
I don't think it applies to 4.4 though as we don't have:
d6760b14d4a1 ("i2c: dev: switch from register_chrdev to cdev API")
I did notice 3 other commits which I've taken in:
5136ed4fcb05 ("i2c-dev: don't get i2c adapter via i2c_dev")
e6be18f6d62c ("i2c: dev: use after free in detach")
72a71f869c95 ("i2c: dev: don't start function name with 'return'")
--
Thanks,
Sasha
next prev parent reply other threads:[~2020-05-21 23:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 19:45 [stable] i2c: dev: Fix the race between the release of i2c_dev and cdev Ben Hutchings
2020-05-21 5:50 ` Greg Kroah-Hartman
2020-05-21 20:58 ` Ben Hutchings
2020-05-21 23:33 ` Sasha Levin [this message]
2020-05-22 11:34 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200521233335.GI33628@sasha-vm \
--to=sashal@kernel.org \
--cc=Alexander.Levin@microsoft.com \
--cc=ben.hutchings@codethink.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox