From: Greg KH <gregkh@linuxfoundation.org>
To: Sasha Levin <sashal@kernel.org>
Cc: mpe@ellerman.id.au, stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] powerpc/64s: Disable STRICT_KERNEL_RWX" failed to apply to 5.4-stable tree
Date: Sat, 23 May 2020 17:08:21 +0200 [thread overview]
Message-ID: <20200523150821.GA196113@kroah.com> (raw)
In-Reply-To: <20200523142614.GT33628@sasha-vm>
On Sat, May 23, 2020 at 10:26:14AM -0400, Sasha Levin wrote:
> On Sat, May 23, 2020 at 02:13:35PM +0200, gregkh@linuxfoundation.org wrote:
> >
> > The patch below does not apply to the 5.4-stable tree.
> > If someone wants it applied there, or to any other stable or longterm
> > tree, then please email the backport, including the original git commit
> > id to <stable@vger.kernel.org>.
> >
> > thanks,
> >
> > greg k-h
> >
> > ------------------ original commit in Linus's tree ------------------
> >
> > > From 8659a0e0efdd975c73355dbc033f79ba3b31e82c Mon Sep 17 00:00:00 2001
> > From: Michael Ellerman <mpe@ellerman.id.au>
> > Date: Wed, 20 May 2020 23:36:05 +1000
> > Subject: [PATCH] powerpc/64s: Disable STRICT_KERNEL_RWX
> >
> > Several strange crashes have been eventually traced back to
> > STRICT_KERNEL_RWX and its interaction with code patching.
> >
> > Various paths in our ftrace, kprobes and other patching code need to
> > be hardened against patching failures, otherwise we can end up running
> > with partially/incorrectly patched ftrace paths, kprobes or jump
> > labels, which can then cause strange crashes.
> >
> > Although fixes for those are in development, they're not -rc material.
> >
> > There also seem to be problems with the underlying strict RWX logic,
> > which needs further debugging.
> >
> > So for now disable STRICT_KERNEL_RWX on 64-bit to prevent people from
> > enabling the option and tripping over the bugs.
> >
> > Fixes: 1e0fc9d1eb2b ("powerpc/Kconfig: Enable STRICT_KERNEL_RWX for some configs")
> > Cc: stable@vger.kernel.org # v4.13+
> > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> > Link: https://lore.kernel.org/r/20200520133605.972649-1-mpe@ellerman.id.au
>
> I also took c55d7b5e6426 ("powerpc: Remove STRICT_KERNEL_RWX
> incompatibility with RELOCATABLE") as a dependency for 5.4 and 4.19, and
> 4ec591e51a4b ("powerpc: restore alphabetic order in Kconfig") for 4.14.
Thanks!
prev parent reply other threads:[~2020-05-23 15:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-23 12:13 FAILED: patch "[PATCH] powerpc/64s: Disable STRICT_KERNEL_RWX" failed to apply to 5.4-stable tree gregkh
2020-05-23 14:26 ` Sasha Levin
2020-05-23 15:08 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200523150821.GA196113@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=mpe@ellerman.id.au \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).