Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: fabrice.gasnier@st.com, Jonathan.Cameron@huawei.com,
	Stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] iio: adc: stm32-dfsdm: fix device used to request dma" failed to apply to 5.4-stable tree
Date: Mon, 25 May 2020 16:52:53 -0400	[thread overview]
Message-ID: <20200525205253.GA33628@sasha-vm> (raw)
In-Reply-To: <159041484016177@kroah.com>

On Mon, May 25, 2020 at 03:54:00PM +0200, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 5.4-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From b455d06e6fb3c035711e8aab1ca18082ccb15d87 Mon Sep 17 00:00:00 2001
>From: Fabrice Gasnier <fabrice.gasnier@st.com>
>Date: Thu, 30 Apr 2020 11:28:46 +0200
>Subject: [PATCH] iio: adc: stm32-dfsdm: fix device used to request dma
>
>DMA channel request should use device struct from platform device struct.
>Currently it's using iio device struct. But at this stage when probing,
>device struct isn't yet registered (e.g. device_register is done in
>iio_device_register). Since commit 71723a96b8b1 ("dmaengine: Create
>symlinks between DMA channels and slaves"), a warning message is printed
>as the links in sysfs can't be created, due to device isn't yet registered:
>- Cannot create DMA slave symlink
>- Cannot create DMA dma:rx symlink
>
>Fix this by using device struct from platform device to request dma chan.
>
>Fixes: eca949800d2d ("IIO: ADC: add stm32 DFSDM support for PDM microphone")
>
>Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
>Cc: <Stable@vger.kernel.org>
>Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

I've also grabbed a9ab624edd91 ("iio: adc: stm32-dfsdm: Use
dma_request_chan() instead dma_request_slave_channel()") and queued both
for 5.4 and 4.19.

-- 
Thanks,
Sasha

      reply	other threads:[~2020-05-25 20:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-25 13:54 FAILED: patch "[PATCH] iio: adc: stm32-dfsdm: fix device used to request dma" failed to apply to 5.4-stable tree gregkh
2020-05-25 20:52 ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200525205253.GA33628@sasha-vm \
    --to=sashal@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=Stable@vger.kernel.org \
    --cc=fabrice.gasnier@st.com \
    --cc=gregkh@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox