From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B58EC433E1 for ; Tue, 26 May 2020 19:05:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B95120873 for ; Tue, 26 May 2020 19:05:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590519923; bh=bTdwv1vyZUg+549OUWqfF6B+jLil2PTqgnQIUtA4yM4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=A+TvscNTSwCHekKTd93my0+dY8z7HAN/49YNCPumyF/eid7yyqQxziC1If6oNXQJi Hid0YrC+v4PyVx5Mo/vLEMshkul74iYvVX2Fmgv22004cpZIibJ6EWGGM+CbcIx6cj Y9puuSLOBh0Cr0S52GV0pYp6gCIC4p/xbWLp+upA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391485AbgEZTFV (ORCPT ); Tue, 26 May 2020 15:05:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:33254 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391494AbgEZTFV (ORCPT ); Tue, 26 May 2020 15:05:21 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5995720873; Tue, 26 May 2020 19:05:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590519920; bh=bTdwv1vyZUg+549OUWqfF6B+jLil2PTqgnQIUtA4yM4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fit/HQf1EYvkUn7bEFfJkoOa/6TcBqH+5RoDolr+gPWeTdwdI/6lbFVediMOnW3X7 T0IXKl8Isbo4Gs2anEgDuTX6WS8aXZLBgbbKrjh4Vajiz85Ul+sySHdXJuoL7x1YJW xpSUDYqXD5yoajmrm6C1Fy7ZY7e+Rauavdo4Yh4g= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?UTF-8?q?=E4=BA=BF=E4=B8=80?= , Alexander Usyskin , Tomas Winkler Subject: [PATCH 4.19 70/81] mei: release me_cl object reference Date: Tue, 26 May 2020 20:53:45 +0200 Message-Id: <20200526183934.821601135@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200526183923.108515292@linuxfoundation.org> References: <20200526183923.108515292@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Alexander Usyskin commit fc9c03ce30f79b71807961bfcb42be191af79873 upstream. Allow me_cl object to be freed by releasing the reference that was acquired by one of the search functions: __mei_me_cl_by_uuid_id() or __mei_me_cl_by_uuid() Cc: Reported-by: 亿一 Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler Link: https://lore.kernel.org/r/20200512223140.32186-1-tomas.winkler@intel.com Signed-off-by: Greg Kroah-Hartman --- drivers/misc/mei/client.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/misc/mei/client.c +++ b/drivers/misc/mei/client.c @@ -276,6 +276,7 @@ void mei_me_cl_rm_by_uuid(struct mei_dev down_write(&dev->me_clients_rwsem); me_cl = __mei_me_cl_by_uuid(dev, uuid); __mei_me_cl_del(dev, me_cl); + mei_me_cl_put(me_cl); up_write(&dev->me_clients_rwsem); } @@ -297,6 +298,7 @@ void mei_me_cl_rm_by_uuid_id(struct mei_ down_write(&dev->me_clients_rwsem); me_cl = __mei_me_cl_by_uuid_id(dev, uuid, id); __mei_me_cl_del(dev, me_cl); + mei_me_cl_put(me_cl); up_write(&dev->me_clients_rwsem); }