From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5868C433E0 for ; Mon, 1 Jun 2020 19:00:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC3CD207DA for ; Mon, 1 Jun 2020 19:00:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591038055; bh=xofEsJup/P0PZFhp+zmnLQl7R5l1RWxKJM++vXMjJFM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=iF334ML4+UE7EHX/bvZPAuCX2Vnd6UUqEqn3Bp1rUNgvVP+KHpNCqbDS8BD1wLKOs cnPjS+jbmCU3Uo20uDqRByVinf18wi/fB6E2K3okjhvj/u4khSu0MWUUa486Eg8ReE MLGOl+fSpY3qiSWUg5GtVWvCEXF+LODHtVPxcHF4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728452AbgFATAv (ORCPT ); Mon, 1 Jun 2020 15:00:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:36522 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728541AbgFAR4O (ORCPT ); Mon, 1 Jun 2020 13:56:14 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3309820842; Mon, 1 Jun 2020 17:56:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591034173; bh=xofEsJup/P0PZFhp+zmnLQl7R5l1RWxKJM++vXMjJFM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PDGdPrAbjLxfhcatzJrOHCA5raSmevoUwp0PwwJBAJATMACxuH8SMjhhkgzBJiIxa 5sHqVlezdpDMEqMty4esCtHVHwPy9bC3Uu0K1q87uscBLH9hCOBll4kxA9WY28mdIA /LHl0R2iPGkGu1MABebBCV0RTKs/4Zhjp41UtKM8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Qiushi Wu , Joerg Roedel , Sasha Levin Subject: [PATCH 4.4 24/48] iommu: Fix reference count leak in iommu_group_alloc. Date: Mon, 1 Jun 2020 19:53:34 +0200 Message-Id: <20200601173959.379801531@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200601173952.175939894@linuxfoundation.org> References: <20200601173952.175939894@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Qiushi Wu [ Upstream commit 7cc31613734c4870ae32f5265d576ef296621343 ] kobject_init_and_add() takes reference even when it fails. Thus, when kobject_init_and_add() returns an error, kobject_put() must be called to properly clean up the kobject. Fixes: d72e31c93746 ("iommu: IOMMU Groups") Signed-off-by: Qiushi Wu Link: https://lore.kernel.org/r/20200527210020.6522-1-wu000273@umn.edu Signed-off-by: Joerg Roedel Signed-off-by: Sasha Levin --- drivers/iommu/iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -206,7 +206,7 @@ again: mutex_lock(&iommu_group_mutex); ida_remove(&iommu_group_ida, group->id); mutex_unlock(&iommu_group_mutex); - kfree(group); + kobject_put(&group->kobj); return ERR_PTR(ret); }