From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10791C433DF for ; Mon, 1 Jun 2020 18:10:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD0662065C for ; Mon, 1 Jun 2020 18:10:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591035036; bh=50HIzBlE5cgtkzhTklOb2NH4NEGz76WiwXFCARxAil4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ecM88c3TwtTlXRDbFFOfB7/4Pg8UB9YjHViK7ijT5b34/a3mkiYrv2oKty05+ThE7 ZeVaHzGviqLj4is1iT5X6HIDTO0WnsnHPJmk7wxVOlNBhAhF9yn0Rv3ahBMey+YRXl 6cytv899Ug7DlnvRyPtpZ5PW9mi1XLE/9gPvIGA0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731006AbgFASKe (ORCPT ); Mon, 1 Jun 2020 14:10:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:57494 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731002AbgFASKd (ORCPT ); Mon, 1 Jun 2020 14:10:33 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BD0602065C; Mon, 1 Jun 2020 18:10:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591035033; bh=50HIzBlE5cgtkzhTklOb2NH4NEGz76WiwXFCARxAil4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X0/zXVC0yL/NDJfKas4Tc8WU4PyPkJawxuT1NFn25kugV/BasF9B923Pqkep/xV8A f7tuD7mPdlZaOvOLG3XZWHp0vrTtBQWGylvE+0LYmANhH+sYZFedq6i/CT9+fJD+lo IVkP7rXTE1x8s6iJ/c2coVFUU0qcMnaBQDSdSsN4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Phil Sutter , Pablo Neira Ayuso Subject: [PATCH 5.4 122/142] netfilter: ipset: Fix subcounter update skip Date: Mon, 1 Jun 2020 19:54:40 +0200 Message-Id: <20200601174050.437373572@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200601174037.904070960@linuxfoundation.org> References: <20200601174037.904070960@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Phil Sutter commit a164b95ad6055c50612795882f35e0efda1f1390 upstream. If IPSET_FLAG_SKIP_SUBCOUNTER_UPDATE is set, user requested to not update counters in sub sets. Therefore IPSET_FLAG_SKIP_COUNTER_UPDATE must be set, not unset. Fixes: 6e01781d1c80e ("netfilter: ipset: set match: add support to match the counters") Signed-off-by: Phil Sutter Signed-off-by: Pablo Neira Ayuso Signed-off-by: Greg Kroah-Hartman --- net/netfilter/ipset/ip_set_list_set.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/netfilter/ipset/ip_set_list_set.c +++ b/net/netfilter/ipset/ip_set_list_set.c @@ -59,7 +59,7 @@ list_set_ktest(struct ip_set *set, const /* Don't lookup sub-counters at all */ opt->cmdflags &= ~IPSET_FLAG_MATCH_COUNTERS; if (opt->cmdflags & IPSET_FLAG_SKIP_SUBCOUNTER_UPDATE) - opt->cmdflags &= ~IPSET_FLAG_SKIP_COUNTER_UPDATE; + opt->cmdflags |= IPSET_FLAG_SKIP_COUNTER_UPDATE; list_for_each_entry_rcu(e, &map->members, list) { ret = ip_set_test(e->id, skb, par, opt); if (ret <= 0)