From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
linux-gpio@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] pinctrl: baytrail: Fix pin being driven low for a while on gpiod_get(..., GPIOD_OUT_HIGH)
Date: Tue, 2 Jun 2020 18:25:55 +0300 [thread overview]
Message-ID: <20200602152555.GJ2428291@smile.fi.intel.com> (raw)
In-Reply-To: <20200602152317.GI2428291@smile.fi.intel.com>
On Tue, Jun 02, 2020 at 06:23:17PM +0300, Andy Shevchenko wrote:
> On Tue, Jun 02, 2020 at 02:21:30PM +0200, Hans de Goede wrote:
...
> Wouldn't be simple below fix the issue?
>
> @@ -1171,14 +1171,10 @@ static int byt_gpio_direction_input(struct gpio_chip *chip, unsigned int offset)
> static int byt_gpio_direction_output(struct gpio_chip *chip,
> unsigned int offset, int value)
> {
> - int ret = pinctrl_gpio_direction_output(chip->base + offset);
> -
> - if (ret)
> - return ret;
> -
> + /* Set value first to avoid a glitch */
> byt_gpio_set(chip, offset, value);
>
> - return 0;
> + return pinctrl_gpio_direction_output(chip->base + offset);
> }
>
>
> P.S. It's mangled, sorry.
Cherrytrail does this way, btw, 549e783f6a1.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-06-02 15:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 12:21 [PATCH] pinctrl: baytrail: Fix pin being driven low for a while on gpiod_get(..., GPIOD_OUT_HIGH) Hans de Goede
2020-06-02 15:23 ` Andy Shevchenko
2020-06-02 15:25 ` Andy Shevchenko [this message]
2020-06-05 14:33 ` Hans de Goede
2020-06-05 17:09 ` Andy Shevchenko
2020-06-05 17:31 ` Hans de Goede
2020-06-05 18:45 ` Andy Shevchenko
2020-06-05 14:10 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602152555.GJ2428291@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox