From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0A48C433DF for ; Tue, 9 Jun 2020 18:13:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A45CD2068D for ; Tue, 9 Jun 2020 18:13:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591726437; bh=3VhzeYCfyFo9o7fz5Vi6e9lrLzkvJTjzxHdMTZtg2QA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=y5SOm87j46w+10OZ9ywZkWO9ZJ89TeAncHMpu/AhCvQqSWvP+U0QdqRoxScEgf1ZG SSMMm06LFDbKF0PT6HSEaI0jIAARdJM3OVUBaQk3pLvHBTTs9KrfE5azPPOSbR4DeH bCGudsHI7qoze9W0H1hO8Ct/FrqfJ+M1SGhtL3+I= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731397AbgFIRux (ORCPT ); Tue, 9 Jun 2020 13:50:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:38950 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732735AbgFIRuu (ORCPT ); Tue, 9 Jun 2020 13:50:50 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 66BF420734; Tue, 9 Jun 2020 17:50:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591725049; bh=3VhzeYCfyFo9o7fz5Vi6e9lrLzkvJTjzxHdMTZtg2QA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uN0MLnAtoDBsoD0V/BXzPYkRNAWgtWzGt4B0u9ZvP1aw22LLOuerHUu+/sVXxaPFO l2nJcF7aSjPiyieIYqxZefQy+Rw/YtXBEzSbHo0+30AaObP8woV1ydOz/x2U/ici// nKjCdc/6rRz3FKfnR1Rhrsh4d2GPJ5kJ0mvXZqRI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yang Yingliang , Cong Wang , "David S. Miller" Subject: [PATCH 4.14 23/46] devinet: fix memleak in inetdev_init() Date: Tue, 9 Jun 2020 19:44:39 +0200 Message-Id: <20200609174026.336557949@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200609174022.938987501@linuxfoundation.org> References: <20200609174022.938987501@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Yang Yingliang [ Upstream commit 1b49cd71b52403822731dc9f283185d1da355f97 ] When devinet_sysctl_register() failed, the memory allocated in neigh_parms_alloc() should be freed. Fixes: 20e61da7ffcf ("ipv4: fail early when creating netdev named all or default") Signed-off-by: Yang Yingliang Acked-by: Cong Wang Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/ipv4/devinet.c | 1 + 1 file changed, 1 insertion(+) --- a/net/ipv4/devinet.c +++ b/net/ipv4/devinet.c @@ -262,6 +262,7 @@ static struct in_device *inetdev_init(st err = devinet_sysctl_register(in_dev); if (err) { in_dev->dead = 1; + neigh_parms_release(&arp_tbl, in_dev->arp_parms); in_dev_put(in_dev); in_dev = NULL; goto out;