From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3565C433DF for ; Thu, 11 Jun 2020 15:51:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 77950206A4 for ; Thu, 11 Jun 2020 15:51:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591890660; bh=ErI4ceKjWlUBsZCR3gl/ZdOkOE5VCsbLegdukdhaPHs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=yhY6lq40FciEvg5ZH+YeQKjIgRqFb1wWv68iWs4ultL3QRGkmBrcnT38ur158fyAp Pr8D6i1fX/tbsQZKd1UorhjKo0dofdt1NKMZp7mZmtfHLlj5YXi3nEzUfiXQpddIVY 7xb8yMmtiMloFwcMrGCr/cUSEbGX7ppsxqL22z8E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728104AbgFKPu7 (ORCPT ); Thu, 11 Jun 2020 11:50:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:44496 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728379AbgFKPuz (ORCPT ); Thu, 11 Jun 2020 11:50:55 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6C54C2075E; Thu, 11 Jun 2020 15:50:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591890654; bh=ErI4ceKjWlUBsZCR3gl/ZdOkOE5VCsbLegdukdhaPHs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jH1K+O4ikdkV4dWtrakfzWVlHm0BhqOO4Qo2/L1c3ouJgqK7SnbLCprorJJbpCQ6a kD5G9t9IhWwvDiZe+iaaZi2Ge8qtC1BWByEJO5+IIodiioNczEemnlS8VXoi42u6t4 xFKIRTC3jOnm9DWO+rsGocKRLTDVadTrZzlt8mu4= Date: Thu, 11 Jun 2020 17:50:48 +0200 From: Greg KH To: Dafna Hirschfeld Cc: linux-media@vger.kernel.org, laurent.pinchart@ideasonboard.com, helen.koike@collabora.com, ezequiel@collabora.com, hverkuil@xs4all.nl, kernel@collabora.com, dafna3@gmail.com, sakari.ailus@linux.intel.com, linux-rockchip@lists.infradead.org, mchehab@kernel.org, tfiga@chromium.org, stable@vger.kernel.org Subject: Re: [RESEND PATCH v3 1/6] media: staging: rkisp1: rsz: supported formats are the isp's src formats, not sink formats Message-ID: <20200611155048.GA1456044@kroah.com> References: <20200611154551.25022-1-dafna.hirschfeld@collabora.com> <20200611154551.25022-2-dafna.hirschfeld@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200611154551.25022-2-dafna.hirschfeld@collabora.com> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Jun 11, 2020 at 05:45:46PM +0200, Dafna Hirschfeld wrote: > The rkisp1_resizer's enum callback 'rkisp1_rsz_enum_mbus_code' > calls the enum callback of the 'rkisp1_isp' on it's video sink pad. > This is a bug, the resizer should support the same formats > supported by the 'rkisp1_isp' on the source pad (not the sink pad). > > Fixes: 56e3b29f9f6b "media: staging: rkisp1: add streaming paths" > > Signed-off-by: Dafna Hirschfeld > Acked-by: Helen Koike > Reviewed-by: Tomasz Figa > --- > drivers/staging/media/rkisp1/rkisp1-resizer.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/media/rkisp1/rkisp1-resizer.c b/drivers/staging/media/rkisp1/rkisp1-resizer.c > index d049374413dc..d64c064bdb1d 100644 > --- a/drivers/staging/media/rkisp1/rkisp1-resizer.c > +++ b/drivers/staging/media/rkisp1/rkisp1-resizer.c > @@ -437,8 +437,8 @@ static int rkisp1_rsz_enum_mbus_code(struct v4l2_subdev *sd, > u32 pad = code->pad; > int ret; > > - /* supported mbus codes are the same in isp sink pad */ > - code->pad = RKISP1_ISP_PAD_SINK_VIDEO; > + /* supported mbus codes are the same in isp video src pad */ > + code->pad = RKISP1_ISP_PAD_SOURCE_VIDEO; > ret = v4l2_subdev_call(&rsz->rkisp1->isp.sd, pad, enum_mbus_code, > &dummy_cfg, code); > > -- > 2.17.1 > This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.