From: Dakshaja Uppalapati <dakshaja@chelsio.com>
To: Keith Busch <kbusch@kernel.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
eduard@hasenleithner.at, sagi@grimberg.me, hch@lst.de,
Nirranjan Kirubaharan <nirranjan@chelsio.com>,
Potnuri Bharat Teja <bharat@chelsio.com>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH nvme] nvme: Revert "nvme: Discard workaround for non-conformant devices"
Date: Thu, 11 Jun 2020 21:38:10 +0530 [thread overview]
Message-ID: <20200611160805.GA9897@chelsio.com> (raw)
In-Reply-To: <20200608150533.GA477@redsun51.ssa.fujisawa.hgst.com>
On Tuesday, June 06/09/20, 2020 at 00:05:33 +0900, Keith Busch wrote:
> On Mon, Jun 08, 2020 at 12:05:44PM +0530, Dakshaja Uppalapati wrote:
> > On Friday, June 06/05/20, 2020 at 15:43:40 +0200, Greg KH wrote:
> > > On Wed, Jun 03, 2020 at 02:48:51PM +0530, Dakshaja Uppalapati wrote:
> > > > This reverts upstream 'commit 530436c45ef2
> > > > ("nvme: Discard workaround for non-conformant devices")'
> > > >
> > > > Since commit `530436c45ef2` introduced a regression due to which
> > > > blk_update_request IO error is observed on formatting device, reverting it.
> > > >
> > > > Fixes: 530436c45ef2 ("nvme: Discard workaround for non-conformant devices")
> > > > Cc: stable <stable@vger.kernel.org> # 4.19+
> > > > Signed-off-by: Dakshaja Uppalapati <dakshaja@chelsio.com>
> > > > ---
> > > > drivers/nvme/host/core.c | 12 +++---------
> > > > 1 file changed, 3 insertions(+), 9 deletions(-)
> > >
> > > This was only for stable?
> > >
> >
> > Yes this is for stable 5.4 and 4.19 branches
>
> No, this revert needs to be rejected. The stable patches need to be the
> upstream equivalent.
Hi keith,
I have sent the required patches which are need to pulled from upstream to
stable 5.4 and 4.19 branches.
Please let me know if you need any further info.
Thanks,
Dakshaja
prev parent reply other threads:[~2020-06-11 16:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 9:18 [PATCH nvme] nvme: Revert "nvme: Discard workaround for non-conformant devices" Dakshaja Uppalapati
2020-06-03 13:07 ` Christoph Hellwig
2020-06-03 16:17 ` Dakshaja Uppalapati
2020-06-03 16:23 ` Christoph Hellwig
2020-06-03 21:20 ` Sagi Grimberg
2020-06-04 6:36 ` Dakshaja Uppalapati
2020-09-04 11:34 ` Greg KH
2020-06-05 13:43 ` Greg KH
2020-06-08 6:35 ` Dakshaja Uppalapati
2020-06-08 15:05 ` Keith Busch
2020-06-11 16:08 ` Dakshaja Uppalapati [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200611160805.GA9897@chelsio.com \
--to=dakshaja@chelsio.com \
--cc=bharat@chelsio.com \
--cc=eduard@hasenleithner.at \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=nirranjan@chelsio.com \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).