From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FE6FC433E0 for ; Mon, 15 Jun 2020 18:56:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4356220656 for ; Mon, 15 Jun 2020 18:56:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731279AbgFOS43 (ORCPT ); Mon, 15 Jun 2020 14:56:29 -0400 Received: from mga11.intel.com ([192.55.52.93]:3787 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729124AbgFOS43 (ORCPT ); Mon, 15 Jun 2020 14:56:29 -0400 IronPort-SDR: nk0k6QHCYGXwPSnFvZFl/dBnL1+74csLAVpziisVevFqUeKK6r/7dfsjBVlgbd9qeQLFicrrzW lP66B+BU4liQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2020 11:56:28 -0700 IronPort-SDR: uue+PSVCk3LyNJiZicIhIpDGOWTgpOaZGd4peX/xPnzbc3riDhuuZbZAGJCTfgo6Mqcp4uk/Pg rrGiau2KiYYQ== X-IronPort-AV: E=Sophos;i="5.73,515,1583222400"; d="scan'208";a="420470061" Received: from rdvivi-losangeles.jf.intel.com (HELO intel.com) ([10.165.21.202]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2020 11:56:28 -0700 Date: Mon, 15 Jun 2020 11:54:20 -0700 From: Rodrigo Vivi To: "Bloomfield, Jon" Cc: "intel-gfx@lists.freedesktop.org" , Alexandre Oliva , "Nikula, Jani" , "stable@vger.kernel.org" , Chris Wilson Subject: Re: [Intel-gfx] [PATCH] drm/i915: Include asm sources for {ivb, hsw}_clear_kernel.c Message-ID: <20200615185420.GA334084@intel.com> References: <159163988890.30073.8976615673203599761@build.alporthouse.com> <20200610201807.191440-1-rodrigo.vivi@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, Jun 12, 2020 at 02:15:02PM -0700, Bloomfield, Jon wrote: > > -----Original Message----- > > From: Intel-gfx On Behalf Of > > Rodrigo Vivi > > Sent: Wednesday, June 10, 2020 1:18 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Alexandre Oliva ; Nikula, Jani ; > > stable@vger.kernel.org; Chris Wilson > > Subject: [Intel-gfx] [PATCH] drm/i915: Include asm sources for {ivb, > > hsw}_clear_kernel.c > > > > Alexandre Oliva has recently removed these files from Linux Libre > > with concerns that the sources weren't available. > > > > The sources are available on IGT repository, and only open source > > tools are used to generate the {ivb,hsw}_clear_kernel.c files. > > > > However, the remaining concern from Alexandre Oliva was around > > GPL license and the source not been present when distributing > > the code. > > > > So, it looks like 2 alternatives are possible, the use of > > linux-firmware.git repository to store the blob or making sure > > that the source is also present in our tree. Since the goal > > is to limit the i915 firmware to only the micro-controller blobs > > let's make sure that we do include the asm sources here in our tree. > > > > Btw, I tried to have some diligence here and make sure that the > > asms that these commits are adding are truly the source for > > the mentioned files: > > > > igt$ ./scripts/generate_clear_kernel.sh -g ivb \ > > -m ~/mesa/build/src/intel/tools/i965_asm > > Output file not specified - using default file "ivb-cb_assembled" > > > > Generating gen7 CB Kernel assembled file "ivb_clear_kernel.c" > > for i915 driver... > > > > igt$ diff ~/i915/drm-tip/drivers/gpu/drm/i915/gt/ivb_clear_kernel.c \ > > ivb_clear_kernel.c > > > > < * Generated by: IGT Gpu Tools on Fri 21 Feb 2020 05:29:32 AM UTC > > > * Generated by: IGT Gpu Tools on Mon 08 Jun 2020 10:00:54 AM PDT > > 61c61 > > < }; > > > }; > > \ No newline at end of file > > > > igt$ ./scripts/generate_clear_kernel.sh -g hsw \ > > -m ~/mesa/build/src/intel/tools/i965_asm > > Output file not specified - using default file "hsw-cb_assembled" > > > > Generating gen7.5 CB Kernel assembled file "hsw_clear_kernel.c" > > for i915 driver... > > > > igt$ diff ~/i915/drm-tip/drivers/gpu/drm/i915/gt/hsw_clear_kernel.c \ > > hsw_clear_kernel.c > > 5c5 > > < * Generated by: IGT Gpu Tools on Fri 21 Feb 2020 05:30:13 AM UTC > > > * Generated by: IGT Gpu Tools on Mon 08 Jun 2020 10:01:42 AM PDT > > 61c61 > > < }; > > > }; > > \ No newline at end of file > > > > Used IGT and Mesa master repositories from Fri Jun 5 2020) > > IGT: 53e8c878a6fb ("tests/kms_chamelium: Force reprobe after replugging > > the connector") > > Mesa: 5d13c7477eb1 ("radv: set keep_statistic_info with > > RADV_DEBUG=shaderstats") > > Mesa built with: meson build -D platforms=drm,x11 -D dri-drivers=i965 \ > > -D gallium-drivers=iris -D prefix=/usr \ > > -D libdir=/usr/lib64/ -Dtools=intel \ > > -Dkulkan-drivers=intel && ninja -C build > > > > v2: Header clean-up and include build instructions in a readme (Chris) > > Modified commit message to respect check-patch > > > > Reference: http://www.fsfla.org/pipermail/linux-libre/2020- > > June/003374.html > > Reference: http://www.fsfla.org/pipermail/linux-libre/2020- > > June/003375.html > > Fixes: 47f8253d2b89 ("drm/i915/gen7: Clear all EU/L3 residual contexts") > > Cc: # v5.7+ > > Cc: Alexandre Oliva > > Cc: Prathap Kumar Valsan > > Cc: Akeem G Abodunrin > > Cc: Mika Kuoppala > > Cc: Chris Wilson > > Cc: Jani Nikula > > Cc: Joonas Lahtinen > > Signed-off-by: Rodrigo Vivi > > Reviewed-by: Jon Bloomfield Thanks, pushed to dinq