From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: franck.lenormand@nxp.com, aisheng.dong@nxp.com,
leonard.crestez@nxp.com, shawnguo@kernel.org,
stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] firmware: imx: scu: Fix corruption of header" failed to apply to 5.7-stable tree
Date: Mon, 15 Jun 2020 17:21:38 -0400 [thread overview]
Message-ID: <20200615212138.GC1931@sasha-vm> (raw)
In-Reply-To: <15922334107128@kroah.com>
On Mon, Jun 15, 2020 at 05:03:30PM +0200, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 5.7-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From f5f27b79eab80de0287c243a22169e4876b08d5e Mon Sep 17 00:00:00 2001
>From: Franck LENORMAND <franck.lenormand@nxp.com>
>Date: Thu, 26 Mar 2020 00:00:05 +0200
>Subject: [PATCH] firmware: imx: scu: Fix corruption of header
>
>The header of the message to send can be changed if the
>response is longer than the request:
> - 1st word, the header is sent
> - the remaining words of the message are sent
> - the response is received asynchronously during the
> execution of the loop, changing the size field in
> the header
> - the for loop test the termination condition using
> the corrupted header
>
>It is the case for the API build_info which has just a
>header as request but 3 words in response.
>
>This issue is fixed storing the header locally instead of
>using a pointer on it.
>
>Fixes: edbee095fafb (firmware: imx: add SCU firmware driver support)
>
>Signed-off-by: Franck LENORMAND <franck.lenormand@nxp.com>
>Reviewed-by: Leonard Crestez <leonard.crestez@nxp.com>
>Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
>Cc: stable@vger.kernel.org
>Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
>Signed-off-by: Shawn Guo <shawnguo@kernel.org>
I've also grabbed f25a066d1a07 ("firmware: imx-scu: Support one TX and
one RX") for 5.7, 5.6, and 5.4.
--
Thanks,
Sasha
prev parent reply other threads:[~2020-06-15 21:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 15:03 FAILED: patch "[PATCH] firmware: imx: scu: Fix corruption of header" failed to apply to 5.7-stable tree gregkh
2020-06-15 21:21 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200615212138.GC1931@sasha-vm \
--to=sashal@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=franck.lenormand@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=leonard.crestez@nxp.com \
--cc=shawnguo@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).