From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: lukas@wunner.de, andriy.shevchenko@linux.intel.com,
broonie@kernel.org, jarkko.nikula@linux.intel.com,
stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] spi: pxa2xx: Fix runtime PM ref imbalance on probe error" failed to apply to 4.19-stable tree
Date: Mon, 15 Jun 2020 20:12:20 -0400 [thread overview]
Message-ID: <20200616001220.GJ1931@sasha-vm> (raw)
In-Reply-To: <15922344972213@kroah.com>
On Mon, Jun 15, 2020 at 05:21:37PM +0200, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 4.19-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From 65e318e17358a3fd4fcb5a69d89b14016dee2f06 Mon Sep 17 00:00:00 2001
>From: Lukas Wunner <lukas@wunner.de>
>Date: Mon, 25 May 2020 14:25:03 +0200
>Subject: [PATCH] spi: pxa2xx: Fix runtime PM ref imbalance on probe error
>
>The PXA2xx SPI driver releases a runtime PM ref in the probe error path
>even though it hasn't acquired a ref earlier.
>
>Apparently commit e2b714afee32 ("spi: pxa2xx: Disable runtime PM if
>controller registration fails") sought to copy-paste the invocation of
>pm_runtime_disable() from pxa2xx_spi_remove(), but erroneously copied
>the call to pm_runtime_put_noidle() as well. Drop it.
>
>Fixes: e2b714afee32 ("spi: pxa2xx: Disable runtime PM if controller registration fails")
>Signed-off-by: Lukas Wunner <lukas@wunner.de>
>Reviewed-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
>Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>Cc: stable@vger.kernel.org # v4.17+
>Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>
>Link: https://lore.kernel.org/r/58b2ac6942ca1f91aaeeafe512144bc5343e1d84.1590408496.git.lukas@wunner.de
>Signed-off-by: Mark Brown <broonie@kernel.org>
I've also grabbed 1274204542f6 ("spi: pxa2xx: Balance runtime PM
enable/disable on error") and worked around the master -> controller
rename. queued for 4.19.
--
Thanks,
Sasha
prev parent reply other threads:[~2020-06-16 0:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 15:21 FAILED: patch "[PATCH] spi: pxa2xx: Fix runtime PM ref imbalance on probe error" failed to apply to 4.19-stable tree gregkh
2020-06-16 0:12 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616001220.GJ1931@sasha-vm \
--to=sashal@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=lukas@wunner.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).