From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9775BC433DF for ; Tue, 16 Jun 2020 01:09:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B6602074D for ; Tue, 16 Jun 2020 01:09:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592269763; bh=RCQWm2OVe9lfFR8CohcCeavVfxrl7jOmzcMj7O5gMHU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=vWvEYU47+wwG32vwvnygm76TKzURHE6G7eKktFMdLwVVQ6SHnr2CSmIGb9Mmew6Sr gIPFDsPpA+D1hrCRC0DFltvLmih0p45SMjyKMEzKCN6v/ueoQfkxE6mWuxX4ynghBt MsN3Ri6YocOQjU59KiufGCzu7qr+qMrKudUZDM8Q= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726757AbgFPBJX (ORCPT ); Mon, 15 Jun 2020 21:09:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:56474 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726327AbgFPBJW (ORCPT ); Mon, 15 Jun 2020 21:09:22 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5032B206D7; Tue, 16 Jun 2020 01:09:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592269762; bh=RCQWm2OVe9lfFR8CohcCeavVfxrl7jOmzcMj7O5gMHU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Qh2n4bj4EpiUm3pT3Gu5Jgv4p9kPJ8tpORPtkXh8uJKo4YvaxQNBZv3C2ks56uYi8 W5In5eaUfdAy3lhmHrQ+wSqEKs7Z1BkxImbLujoWu02mW6HuoTNd2DM9ylhgfYFXbz va59cyu6bY+4fc/KbF1LrH2z1D+lXT79NUcto/s8= Date: Mon, 15 Jun 2020 21:09:21 -0400 From: Sasha Levin To: gregkh@linuxfoundation.org Cc: longpeng2@huawei.com, arei.gonglei@huawei.com, clabbe@baylibre.com, davem@davemloft.net, herbert@gondor.apana.org.au, jasowang@redhat.com, mst@redhat.com, stable@vger.kernel.org Subject: Re: FAILED: patch "[PATCH] crypto: virtio: Fix src/dst scatterlist calculation in" failed to apply to 5.4-stable tree Message-ID: <20200616010921.GM1931@sasha-vm> References: <15922523850161@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <15922523850161@kroah.com> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Jun 15, 2020 at 10:19:45PM +0200, gregkh@linuxfoundation.org wrote: > >The patch below does not apply to the 5.4-stable tree. >If someone wants it applied there, or to any other stable or longterm >tree, then please email the backport, including the original git commit >id to . > >thanks, > >greg k-h > >------------------ original commit in Linus's tree ------------------ > >>From b02989f37fc5e865ceeee9070907e4493b3a21e2 Mon Sep 17 00:00:00 2001 >From: "Longpeng(Mike)" >Date: Tue, 2 Jun 2020 15:04:59 +0800 >Subject: [PATCH] crypto: virtio: Fix src/dst scatterlist calculation in > __virtio_crypto_skcipher_do_req() > >The system will crash when the users insmod crypto/tcrypt.ko with mode=38 >( testing "cts(cbc(aes))" ). > >Usually the next entry of one sg will be @sg@ + 1, but if this sg element >is part of a chained scatterlist, it could jump to the start of a new >scatterlist array. Fix it by sg_next() on calculation of src/dst >scatterlist. > >Fixes: dbaf0624ffa5 ("crypto: add virtio-crypto driver") >Reported-by: LABBE Corentin >Cc: Herbert Xu >Cc: "Michael S. Tsirkin" >Cc: Jason Wang >Cc: "David S. Miller" >Cc: virtualization@lists.linux-foundation.org >Cc: linux-kernel@vger.kernel.org >Cc: stable@vger.kernel.org >Link: https://lore.kernel.org/r/20200123101000.GB24255@Red >Signed-off-by: Gonglei >Signed-off-by: Longpeng(Mike) >Link: https://lore.kernel.org/r/20200602070501.2023-2-longpeng2@huawei.com >Signed-off-by: Michael S. Tsirkin I've worked around missing eee1d6fca0a0 ("crypto: virtio - switch to skcipher API") and queued it for 5.4, 4.19, and 4.14. -- Thanks, Sasha