From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E342DC433E0 for ; Tue, 16 Jun 2020 01:14:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8256206DB for ; Tue, 16 Jun 2020 01:14:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592270052; bh=7aUm0dopw7cgOhYt4RoQJS84uWHe6Bpg7pjzMRJYXrs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=sA+2R41b3D2HgKq+p1TI1nr1Zff0HlulwJLjJUixLBo02uYEGDoxQ99ZEGUzYC7Et a8y+BDSprv979eoD0cyrQ5yQcrnMl/F1bp7LBu879EJhOYrXmN6xSzhRWLXEC3KlOu Nx8Le2WOkDRG4fQ4rOp589lw8PcsE87DzZMjfBQk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726836AbgFPBOM (ORCPT ); Mon, 15 Jun 2020 21:14:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:57658 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726492AbgFPBOK (ORCPT ); Mon, 15 Jun 2020 21:14:10 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 47D1F206D8; Tue, 16 Jun 2020 01:14:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592270049; bh=7aUm0dopw7cgOhYt4RoQJS84uWHe6Bpg7pjzMRJYXrs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gQ1qWBhlLR4NMOJIdn7yKrf4jGtPbYG2dkGKjMbdnhkoqtTYQ6xhiGZSVSnPsS3t0 hckL7cFsqtqoqU0zoWospZ42f8kMJZ8DkaKRVWhE38Z2JP41LV7ba5r5+lLKLIpX/I ontToAAloGnmfokSdU3o2aeRxwmMfTvNFdUE+kOY= Date: Mon, 15 Jun 2020 21:14:08 -0400 From: Sasha Levin To: gregkh@linuxfoundation.org Cc: longpeng2@huawei.com, arei.gonglei@huawei.com, davem@davemloft.net, herbert@gondor.apana.org.au, jasowang@redhat.com, mst@redhat.com, stable@vger.kernel.org Subject: Re: FAILED: patch "[PATCH] crypto: virtio: Fix dest length calculation in" failed to apply to 5.4-stable tree Message-ID: <20200616011408.GN1931@sasha-vm> References: <159225302411542@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <159225302411542@kroah.com> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Jun 15, 2020 at 10:30:24PM +0200, gregkh@linuxfoundation.org wrote: > >The patch below does not apply to the 5.4-stable tree. >If someone wants it applied there, or to any other stable or longterm >tree, then please email the backport, including the original git commit >id to . > >thanks, > >greg k-h > >------------------ original commit in Linus's tree ------------------ > >>From d90ca42012db2863a9a30b564a2ace6016594bda Mon Sep 17 00:00:00 2001 >From: "Longpeng(Mike)" >Date: Tue, 2 Jun 2020 15:05:01 +0800 >Subject: [PATCH] crypto: virtio: Fix dest length calculation in > __virtio_crypto_skcipher_do_req() > >The src/dst length is not aligned with AES_BLOCK_SIZE(which is 16) in some >testcases in tcrypto.ko. > >For example, the src/dst length of one of cts(cbc(aes))'s testcase is 17, the >crypto_virtio driver will set @src_data_len=16 but @dst_data_len=17 in this >case and get a wrong at then end. > > SRC: pp pp pp pp pp pp pp pp pp pp pp pp pp pp pp pp pp (17 bytes) > EXP: cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc pp (17 bytes) > DST: cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc 00 (pollute the last bytes) > (pp: plaintext cc:ciphertext) > >Fix this issue by limit the length of dest buffer. > >Fixes: dbaf0624ffa5 ("crypto: add virtio-crypto driver") >Cc: Gonglei >Cc: Herbert Xu >Cc: "Michael S. Tsirkin" >Cc: Jason Wang >Cc: "David S. Miller" >Cc: virtualization@lists.linux-foundation.org >Cc: linux-kernel@vger.kernel.org >Cc: stable@vger.kernel.org >Signed-off-by: Longpeng(Mike) >Link: https://lore.kernel.org/r/20200602070501.2023-4-longpeng2@huawei.com >Signed-off-by: Michael S. Tsirkin Conflict due to missing eee1d6fca0a0 ("crypto: virtio - switch to skcipher API"). I've fixed it and queued up for 5.4, 4.19, and 4.14. -- Thanks, Sasha