From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75B2AC433E1 for ; Thu, 18 Jun 2020 01:57:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4BB0221924 for ; Thu, 18 Jun 2020 01:57:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592445426; bh=oz9WUU05V+vR5SeYhnmeKUgrS8zd6RKplIzjiqi8ZWI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=w0hb0PXTr6HOw1NjBKU6BnQAbChP2N/uVRAj5P3FTujR4giiRHEwrcqVcxNBRlvOg jzZ76pSBzoOmyVs3nP1CvWCX+hiUmYh99T0yD+H2OrbxeUboE7ewQ1eUDnJ45P8v2l u2AfWRNNCESQxo0/QakocojSRRdQ3HYshUnCdj3Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733289AbgFRB5F (ORCPT ); Wed, 17 Jun 2020 21:57:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:60280 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731373AbgFRBZM (ORCPT ); Wed, 17 Jun 2020 21:25:12 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8AF04221EE; Thu, 18 Jun 2020 01:25:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592443512; bh=oz9WUU05V+vR5SeYhnmeKUgrS8zd6RKplIzjiqi8ZWI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KJ6rWp3p1PRgwzGkqne1aSSL7LHUbCYhLTVixi8/QrzXuRnBZ4wb538lZmn3aHAhd ButQ2+7g4EGSWk/K4KINcTfaoM/uXGEdLjj9F1LTzXmJ7zZbiGcQsE+ZuMsOv2Zlvt pcAvvbJS/26odpp56SsD19RmhfN6sWZBLr1l95gA= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Stafford Horne , Sasha Levin , openrisc@lists.librecores.org Subject: [PATCH AUTOSEL 4.19 136/172] openrisc: Fix issue with argument clobbering for clone/fork Date: Wed, 17 Jun 2020 21:21:42 -0400 Message-Id: <20200618012218.607130-136-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200618012218.607130-1-sashal@kernel.org> References: <20200618012218.607130-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Stafford Horne [ Upstream commit 6bd140e14d9aaa734ec37985b8b20a96c0ece948 ] Working on the OpenRISC glibc port I found that sometimes clone was working strange. That the tls data argument sent in r7 was always wrong. Further investigation revealed that the arguments were getting clobbered in the entry code. This patch removes the code that writes to the argument registers. This was likely due to some old code hanging around. This patch fixes this up for clone and fork. This fork clobber is harmless but also useless so remove. Signed-off-by: Stafford Horne Signed-off-by: Sasha Levin --- arch/openrisc/kernel/entry.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/openrisc/kernel/entry.S b/arch/openrisc/kernel/entry.S index ee6159d2ed22..01b59d2ce174 100644 --- a/arch/openrisc/kernel/entry.S +++ b/arch/openrisc/kernel/entry.S @@ -1170,13 +1170,13 @@ ENTRY(__sys_clone) l.movhi r29,hi(sys_clone) l.ori r29,r29,lo(sys_clone) l.j _fork_save_extra_regs_and_call - l.addi r7,r1,0 + l.nop ENTRY(__sys_fork) l.movhi r29,hi(sys_fork) l.ori r29,r29,lo(sys_fork) l.j _fork_save_extra_regs_and_call - l.addi r3,r1,0 + l.nop ENTRY(sys_rt_sigreturn) l.jal _sys_rt_sigreturn -- 2.25.1