From: Sasha Levin <sashal@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: pasha.tatashin@soleen.com, akpm@linux-foundation.org,
dan.j.williams@intel.com, daniel.m.jordan@oracle.com,
david@redhat.com, jmorris@namei.org, ktkhai@virtuozzo.com,
mhocko@suse.com, pankaj.gupta.linux@gmail.com,
shile.zhang@linux.alibaba.com, stable@vger.kernel.org,
torvalds@linux-foundation.org, vbabka@suse.cz, yiwei@redhat.com
Subject: Re: FAILED: patch "[PATCH] mm: call cond_resched() from deferred_init_memmap()" failed to apply to 5.7-stable tree
Date: Thu, 18 Jun 2020 22:28:22 -0400 [thread overview]
Message-ID: <20200619022822.GV1931@sasha-vm> (raw)
In-Reply-To: <20200618162649.GA250996@kroah.com>
On Thu, Jun 18, 2020 at 06:26:49PM +0200, Greg KH wrote:
>On Thu, Jun 18, 2020 at 05:55:43PM +0200, gregkh@linuxfoundation.org wrote:
>>
>> The patch below does not apply to the 5.7-stable tree.
>> If someone wants it applied there, or to any other stable or longterm
>> tree, then please email the backport, including the original git commit
>> id to <stable@vger.kernel.org>.
>
>Oops, I applied things out of order, I've queued this and the 5.4
>version up, but 4.19 doesn't apply as the dependant patch does not
>apply.
Something like this should work?
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 7181dfe76440..b7905a075e79 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1611,11 +1611,13 @@ static int __init deferred_init_memmap(void *data)
spfn = max_t(unsigned long, first_init_pfn, PFN_UP(spa));
epfn = min_t(unsigned long, zone_end_pfn(zone), PFN_DOWN(epa));
nr_pages += deferred_init_pages(nid, zid, spfn, epfn);
+ cond_resched();
}
for_each_free_mem_range(i, nid, MEMBLOCK_NONE, &spa, &epa, NULL) {
spfn = max_t(unsigned long, first_init_pfn, PFN_UP(spa));
epfn = min_t(unsigned long, zone_end_pfn(zone), PFN_DOWN(epa));
deferred_free_pages(nid, zid, spfn, epfn);
+ cond_resched();
}
/* Sanity check that the next zone really is unpopulated */
--
Thanks,
Sasha
next prev parent reply other threads:[~2020-06-19 2:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 15:55 FAILED: patch "[PATCH] mm: call cond_resched() from deferred_init_memmap()" failed to apply to 5.7-stable tree gregkh
2020-06-18 16:26 ` Greg KH
2020-06-19 2:28 ` Sasha Levin [this message]
2020-06-19 9:21 ` Michal Hocko
2020-06-19 9:43 ` David Hildenbrand
2020-06-19 12:15 ` Pavel Tatashin
2020-06-19 12:27 ` David Hildenbrand
2020-06-19 12:43 ` Pavel Tatashin
2020-06-19 13:26 ` Pavel Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200619022822.GV1931@sasha-vm \
--to=sashal@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=daniel.m.jordan@oracle.com \
--cc=david@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jmorris@namei.org \
--cc=ktkhai@virtuozzo.com \
--cc=mhocko@suse.com \
--cc=pankaj.gupta.linux@gmail.com \
--cc=pasha.tatashin@soleen.com \
--cc=shile.zhang@linux.alibaba.com \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
--cc=yiwei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).