From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2262CC433DF for ; Fri, 19 Jun 2020 16:53:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED45620734 for ; Fri, 19 Jun 2020 16:53:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592585626; bh=rGtfVHMuIXLp77viLsLkSkb8XC+fGEJceN3uMHfOGkM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=etnBpJCTMPtUpOZhRMLaDcVgt8p4xi0bTyOYpYxM/WfrwUS8T5mOdcNmpo+WTa5xp yK+MpylS6tVRktec2NJ707JJkTpJ0i/wJdAlxk3ppuRtxmMp9mPStOa98MeNGBBZ25 vMSsazIvfq3y0ZJYoERrBtdwK94KUuV3350oW/NI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436526AbgFSQxo (ORCPT ); Fri, 19 Jun 2020 12:53:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:53766 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387644AbgFSOhA (ORCPT ); Fri, 19 Jun 2020 10:37:00 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 083D520CC7; Fri, 19 Jun 2020 14:36:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592577419; bh=rGtfVHMuIXLp77viLsLkSkb8XC+fGEJceN3uMHfOGkM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mfoDeO5dAhorTSRsSfTyg5fWkqGrjYCtPXHYEYqSTE9YbHM5DMrBspGg9RSGOn/t8 GZHGkhFbJeqctyRdX5xfH+NuxDZefkQL4Vvfe/Gj7xOUVBx9pwGr6EGLAur0dpRzwW r4Y/dv557QCPkwT/3TbHqIrgsmgUYIebj6vqYa8E= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+6f1624f937d9d6911e2d@syzkaller.appspotmail.com, OGAWA Hirofumi , Andrew Morton , Marco Elver , Dmitry Vyukov , Linus Torvalds Subject: [PATCH 4.4 044/101] fat: dont allow to mount if the FAT length == 0 Date: Fri, 19 Jun 2020 16:32:33 +0200 Message-Id: <20200619141616.410416668@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619141614.001544111@linuxfoundation.org> References: <20200619141614.001544111@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: OGAWA Hirofumi commit b1b65750b8db67834482f758fc385bfa7560d228 upstream. If FAT length == 0, the image doesn't have any data. And it can be the cause of overlapping the root dir and FAT entries. Also Windows treats it as invalid format. Reported-by: syzbot+6f1624f937d9d6911e2d@syzkaller.appspotmail.com Signed-off-by: OGAWA Hirofumi Signed-off-by: Andrew Morton Cc: Marco Elver Cc: Dmitry Vyukov Link: http://lkml.kernel.org/r/87r1wz8mrd.fsf@mail.parknet.co.jp Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- fs/fat/inode.c | 6 ++++++ 1 file changed, 6 insertions(+) --- a/fs/fat/inode.c +++ b/fs/fat/inode.c @@ -1422,6 +1422,12 @@ static int fat_read_bpb(struct super_blo goto out; } + if (bpb->fat_fat_length == 0 && bpb->fat32_length == 0) { + if (!silent) + fat_msg(sb, KERN_ERR, "bogus number of FAT sectors"); + goto out; + } + error = 0; out: