From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68A3DC433E0 for ; Fri, 19 Jun 2020 15:34:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3B81020734 for ; Fri, 19 Jun 2020 15:34:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592580888; bh=59NqwUWWhjfYF1vPj0tVIAxyPg99f5wPdqso9o8QcF4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=H76E1E18vzj1thcqTNwU4KH40HIV/vNB9z1sn3DP7iI36Rr4gEJafbj13HMJOtCP6 ZkpktYdLOQROaYydj7i6eBX6IBM0+ymlTVT4LKsZ5gPk+9rW+1iHLtN8KPOcoMCxS/ 6d02TYOVIXIkuP6Wjrz4GnUewCwsQKvbLz92076U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404592AbgFSPer (ORCPT ); Fri, 19 Jun 2020 11:34:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:36208 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393882AbgFSPcO (ORCPT ); Fri, 19 Jun 2020 11:32:14 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BFC4220757; Fri, 19 Jun 2020 15:32:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592580734; bh=59NqwUWWhjfYF1vPj0tVIAxyPg99f5wPdqso9o8QcF4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IUYewPCxIzHCt+IwlqupnEXQakbcAjEsOndMe10wG7QJzbMx+1euln0dEuVWHAprk oD87Ol+tMI4d0GbRuJXKXbTPBWNqp9H4ShYqTlqv7yau5YLK+v2Z96RBL/iRWP717z txm/u30R0an3RFV7K3ODd4wAZnpQDx0GtAJjdhCw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miquel Raynal Subject: [PATCH 5.7 362/376] mtd: rawnand: sunxi: Fix the probe error path Date: Fri, 19 Jun 2020 16:34:40 +0200 Message-Id: <20200619141727.450683000@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619141710.350494719@linuxfoundation.org> References: <20200619141710.350494719@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Miquel Raynal commit 3d84515ffd8fb657e10fa5b1215e9f095fa7efca upstream. nand_release() is supposed be called after MTD device registration. Here, only nand_scan() happened, so use nand_cleanup() instead. Fixes: 1fef62c1423b ("mtd: nand: add sunxi NAND flash controller support") Signed-off-by: Miquel Raynal Cc: stable@vger.kernel.org Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-54-miquel.raynal@bootlin.com Signed-off-by: Greg Kroah-Hartman --- drivers/mtd/nand/raw/sunxi_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/mtd/nand/raw/sunxi_nand.c +++ b/drivers/mtd/nand/raw/sunxi_nand.c @@ -2003,7 +2003,7 @@ static int sunxi_nand_chip_init(struct d ret = mtd_device_register(mtd, NULL, 0); if (ret) { dev_err(dev, "failed to register mtd device: %d\n", ret); - nand_release(nand); + nand_cleanup(nand); return ret; }