From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF481C433DF for ; Mon, 22 Jun 2020 11:24:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 90E8B20739 for ; Mon, 22 Jun 2020 11:24:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728937AbgFVLYT (ORCPT ); Mon, 22 Jun 2020 07:24:19 -0400 Received: from stargate.chelsio.com ([12.32.117.8]:29822 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729438AbgFVLYQ (ORCPT ); Mon, 22 Jun 2020 07:24:16 -0400 Received: from localhost (moto.blr.asicdesigners.com [10.193.184.79] (may be forged)) by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id 05MBLnGV015086; Mon, 22 Jun 2020 04:21:50 -0700 Date: Mon, 22 Jun 2020 16:51:44 +0530 From: Dakshaja Uppalapati To: Keith Busch Cc: linux-nvme@lists.infradead.org, eduard@hasenleithner.at, sagi@grimberg.me, hch@lst.de, stable@vger.kernel.org, Nirranjan Kirubaharan , Potnuri Bharat Teja Subject: Re: [PATCH for-stable nvmet 0/6] nvme: Fix for blk_update_request IO error. Message-ID: <20200622112143.GA25601@chelsio.com> References: <20200611155339.9429-1-dakshaja@chelsio.com> <20200617141541.GA712019@dhcp-10-100-145-180.wdl.wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200617141541.GA712019@dhcp-10-100-145-180.wdl.wdc.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wednesday, June 06/17/20, 2020 at 07:15:41 -0700, Keith Busch wrote: > On Thu, Jun 11, 2020 at 09:23:33PM +0530, Dakshaja Uppalapati wrote: > > The below error is seen in dmesg, while formatting the disks discovered on host. > > > > dmesg: > > [ 636.733374] blk_update_request: I/O error, dev nvme4n1, sector 0 op 0x3:(DISCARD) flags 0x800 phys_seg 1 prio class 0 > > > > Patch 6 fixes it and there are 5 other dependent patches that also need to be > > pulled from upstream to stable, 5.4 and 4.19 branches. > > > > Patch 1 dependent patch > > > > Patch 2 dependent patch > > > > Patch 3 dependent patch > > > > Patch 4 dependent patch > > > > Patch 5 dependent patch > > > > Patch 6 fix patch > > 1. You need to copy the linux-nvme mainling list for linux nvme kernel patches. > > 2. If you're sending someone else's patch, the patch is supposed to have > the From: tag so the author is appropriately identified. > > 3. Stable patches must referece the upstream commit ID. > > As for this particular issue, while stable patches are required to > reference an upstream commit, you don't need to bring in dependent > patches. You are allowed to write an equivalent fix specific to the > stable branch so that stable doesn't need to take a bunch of unrelated > changes. For example, it looks like this particular isssue can be fixed > with the following simple stable patch: > Hi keith, Thanks for the review. I initially tried pushing only the fix + required portion of the dependent patches(https://www.spinics.net/lists/stable/msg387744.html) but as that approach is discouraged in stable tree, I submitted all the patches as it is. Here are the ways to fix the issue in stable tree: • push fix + all dependent patches • push fix + custom patch of dependent patches • revert the culprit patch. Please let me know how this issue can be resolved in stable tree. Thanks, Dakshaja