From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5FD5C433DF for ; Tue, 23 Jun 2020 20:44:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7AC0421BE5 for ; Tue, 23 Jun 2020 20:44:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592945085; bh=/9j2O4ndIpMwdAF1ANDZkBH6qIBFbszMf8SV8brBx6o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Rcb7HHUwk7vU9ONV4tDsZqxgTrP/PEEXdHbf/xBAE8KHEKHB55DwX54XJnFR3jSqJ xk8uvITgEHixL02pFxMdFSYCU5rg4VjAvVIOB6551ICi3quoU/QYKfMf5mhXPVvPuY C8F+Iha86N7lfPuZjVJ7sHiHRMC+LjsFsByIadUY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392597AbgFWUom (ORCPT ); Tue, 23 Jun 2020 16:44:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:41914 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391022AbgFWUoj (ORCPT ); Tue, 23 Jun 2020 16:44:39 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 93D4E218AC; Tue, 23 Jun 2020 20:44:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592945080; bh=/9j2O4ndIpMwdAF1ANDZkBH6qIBFbszMf8SV8brBx6o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Il2byrHGTqdbj9R0vk1pjzXsQoafaeAu8uHa1yf4YkWWLXXkWWh4KaEH7HND/ZrzG d5mGh5+IEdGS/oofUhGwgZD5uYOonkgcqNPQO/IKVE1//J7d6+kg96A4rGkHHA3E0d sBgqxJQQpMhLh/89B8SSyoL3SWEUYgKv6iDlg6Fs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Wang Hai , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 030/136] yam: fix possible memory leak in yam_init_driver Date: Tue, 23 Jun 2020 21:58:06 +0200 Message-Id: <20200623195305.169665860@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195303.601828702@linuxfoundation.org> References: <20200623195303.601828702@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Wang Hai [ Upstream commit 98749b7188affbf2900c2aab704a8853901d1139 ] If register_netdev(dev) fails, free_netdev(dev) needs to be called, otherwise a memory leak will occur. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Reported-by: Hulk Robot Signed-off-by: Wang Hai Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/hamradio/yam.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c index 16a6e11939122..b74c735a423dd 100644 --- a/drivers/net/hamradio/yam.c +++ b/drivers/net/hamradio/yam.c @@ -1162,6 +1162,7 @@ static int __init yam_init_driver(void) err = register_netdev(dev); if (err) { printk(KERN_WARNING "yam: cannot register net device %s\n", dev->name); + free_netdev(dev); goto error; } yam_devs[i] = dev; -- 2.25.1